Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dev):remoteAddress might be undefined for x-forwarded-for #2198

Merged
merged 3 commits into from
Feb 29, 2024
Merged

fix(dev):remoteAddress might be undefined for x-forwarded-for #2198

merged 3 commits into from
Feb 29, 2024

Conversation

manniL
Copy link
Contributor

@manniL manniL commented Feb 29, 2024

🔗 Linked issue

Resolves #2197

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@manniL manniL requested a review from pi0 February 29, 2024 10:38
@manniL manniL mentioned this pull request Feb 29, 2024
Closed
pi0
pi0 reviewed Feb 29, 2024
View reviewed changes
src/dev/server.ts Show resolved Hide resolved
@pi0 pi0 changed the title fix: only set x-forwarded-for when exists fix(dev):remoteAddress might be undefined for x-forwarded-for Feb 29, 2024
pi0
pi0 approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 044721a into main Feb 29, 2024
4 of 5 checks passed
@pi0 pi0 deleted the fix/x-forwarded branch February 29, 2024 10:47
@Barbapapazes Barbapapazes mentioned this pull request Aug 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

x-forwared-for error on stackblitz
2 participants
@manniL @pi0