Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dev):remoteAddress might be undefined for x-forwarded-for #2198

Merged
merged 3 commits into from
Feb 29, 2024
Merged

fix(dev):remoteAddress might be undefined for x-forwarded-for #2198

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ca6361
fix: only set x-forwarded-for when exists
manniL Feb 29, 2024
a812963
chore: apply automated fixes
autofix-ci[bot] Feb 29, 2024
fcbd301
Update src/dev/server.ts
pi0 Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/dev/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,11 @@ export function createDevServer(nitro: Nitro): NitroDevServer {
proxy.proxy.on("proxyReq", (proxyReq, req) => {
// TODO: Use httpxy to set these headers
if (!proxyReq.hasHeader("x-forwarded-for")) {
proxyReq.appendHeader("x-forwarded-for", req.socket.remoteAddress);
const address = req.socket.remoteAddress;
// #2197
if (address) {
pi0 marked this conversation as resolved.
Show resolved Hide resolved
proxyReq.appendHeader("x-forwarded-for", address);
}
}
if (!proxyReq.hasHeader("x-forwarded-port")) {
const localPort = req?.socket?.localPort;
Expand Down
Loading