Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add from_owned_fd constructor to EventFd #2563

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Add from_owned_fd constructor to EventFd #2563

merged 3 commits into from
Dec 17, 2024

Conversation

chadaustin
Copy link
Contributor

@chadaustin chadaustin commented Dec 16, 2024 •
edited
Loading

Allow creating an EventFd from an OwnedFd acquired from another process.

Fixes #2561

@chadaustin
Copy link
Contributor Author

Let me know if a test would make sense.

SteveLauC
SteveLauC approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@SteveLauC
Copy link
Member

Let me know if a test would make sense.

No need to have tests, this logic here is quite simple:)

@SteveLauC SteveLauC added this pull request to the merge queue Dec 17, 2024
Merged via the queue into nix-rust:master with commit 5674377 Dec 17, 2024
40 checks passed
@SteveLauC SteveLauC mentioned this pull request Dec 18, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveLauC SteveLauC SteveLauC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EventFd has no conversion from OwnedFd
2 participants
@chadaustin @SteveLauC