Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change import path to v4 #249

Merged
merged 9 commits into from
Nov 9, 2023
Merged

chore: change import path to v4 #249

merged 9 commits into from
Nov 9, 2023

Conversation

johnletey
Copy link
Member

@johnletey johnletey commented Oct 17, 2023

This PR changes our import path to include v4 to correctly align ourselves with Go's naming convention.

It requires the dependency work done in #259, and should be merged after v4.0.0 is released!

@johnletey johnletey requested review from agouin and boojamya October 17, 2023 11:16
@johnletey johnletey self-assigned this Oct 17, 2023
go.mod Outdated Show resolved Hide resolved
Base automatically changed from john/remove-router to main October 17, 2023 17:11
@johnletey johnletey changed the base branch from main to john/migrate-fiattokenfactory November 1, 2023 13:01
@johnletey johnletey marked this pull request as draft November 1, 2023 13:23
Base automatically changed from john/migrate-fiattokenfactory to main November 9, 2023 16:03
@johnletey johnletey marked this pull request as ready for review November 9, 2023 18:24
@johnletey johnletey requested a review from agouin November 9, 2023 18:24
Copy link
Member

@boojamya boojamya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

proto/globalfee/query.proto Show resolved Hide resolved
@johnletey johnletey merged commit 493fd8b into main Nov 9, 2023
23 checks passed
@johnletey johnletey deleted the john/import-path branch November 9, 2023 23:09
@johnletey
Copy link
Member Author

@Mergifyio backport release/v4.1.x

Copy link

mergify bot commented Nov 11, 2023

backport release/v4.1.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants