Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring-up xml-crypto to 1.4.0 #400

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Bring-up xml-crypto to 1.4.0 #400

merged 1 commit into from
Nov 18, 2019

Conversation

LoneRifle
Copy link
Contributor

This update will pick up the following changes:

node-saml/xml-crypto#171
node-saml/xml-crypto#179
node-saml/xml-crypto#183

@markstos
Copy link
Contributor

@LoneRifle I see you appear to be a commiter for xml-crypto. I appreciate the nudge here, but do these changes fix known bugs in passport-saml?

@cjbarth
Copy link
Collaborator

cjbarth commented Nov 18, 2019

I don't know of any reported bugs to this project that this would fix, however node-saml/xml-crypto#164, which is fixed in this proposed update, covers a scenario that could affect users of this library.

@cjbarth
Copy link
Collaborator

cjbarth commented Nov 18, 2019

Side note, it seems the CI build failed because we are specifying testing be done with an out-dated version of Node.

@markstos markstos merged commit c82149d into node-saml:master Nov 18, 2019
@markstos
Copy link
Contributor

@cjbarth That looks like a legit reason to upgrade. I'm bumping this dependency.

Regarding the CI failures due to old Node.js versions. Are you referring to the .travis.yml file? We bumped the Node.js version is that about a month ago: https://github.com/bergie/passport-saml/blob/master/.travis.yml#L3

@LoneRifle LoneRifle deleted the patch-1 branch November 19, 2019 00:38
@cjbarth
Copy link
Collaborator

cjbarth commented Nov 19, 2019

So we did. Consider this closed then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants