Fix canon xml being computed differently when signing, than when verifying #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fying When computing the signature, ancestor namespaces of SignedInfo and reference node were not passed into the 'getCanonXml' method like they were during signature verification This attempts to fix node-saml#164
LoneRifle
approved these changes
Apr 26, 2019
markstos
pushed a commit
to node-saml/passport-saml
that referenced
this pull request
Nov 18, 2019
This update will pick up the following changes: node-saml/xml-crypto#171 node-saml/xml-crypto#179 node-saml/xml-crypto#183
cjbarth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When computing the signature, ancestor namespaces of SignedInfo and
reference node were not passed into the 'getCanonXml' method like
they are during signature verification
This attempts to fix #164