Updated getKeyInfo function with actual implementation

[ganesha289]

Hello @cjbarth, @LoneRifle, @yaronn,
I have added implementation for getKeyInfo function, please check if it looks good, then I'll proceed with unit tests.

I am getting confused with below line of codes,

For FileKeyInfo, I'm assuming it accepts file which will be public X509 certificate and this.getKeyInfo function will return the X509Data. But, what is the use of this.getKey()?? I'm assuming it will return public certificate. But, in some places it used as privateKey, as shown in below statements,

In node-saml->src->xml.ts->signXml, signingKey gets the privateKey value assigned, as shown below,

However, in xml-crypto->lib->signed-sml.js, signingKey gets the value from KeyInfoProvider.getKey(this.keyInfo) which looks to be public certificate..

Can you please help me to clear this..

[cjbarth]

@ganesha289 , I'm not sure what the confusion is. Signing should be done with a private key and verification of a signature is done with a public key. The code that you reference in signed-xml.js is part of the function called checkSignature, so it would make sense that it would use a public cert. As for node-saml, that looks like it is correctly using a private key to sign an XML document.

[cjbarth]

@ganesha289 I think we have a general idea of how we'd like to move forward. Since @LoneRifle and I are pretty much the only ones left doing anything that looks like maintenance on this project, I think the three of us can figure out the correct pattern here, implement it, and close this out. I know node-saml will benefit from it, and I expect others will too, especially if the pattern is clearly established.

[LoneRifle]

lgtm