-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue in case when namespace has no prefix #330
Conversation
Codecov Report
@@ Coverage Diff @@
## master #330 +/- ##
==========================================
+ Coverage 82.49% 82.88% +0.38%
==========================================
Files 7 7
Lines 777 777
==========================================
+ Hits 641 644 +3
+ Misses 136 133 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Can you do me a favor and make a PR against this branch with these changes too? That would help prevent this code from being lost during the migration to TS. |
I'm working on this. It seems there are a few more types that need to be tightened up and otherwise corrected. |
@git9527 , don't worry about the compilation errors, just make a PR against #325 and I'll fix that kind of stuff when I'm working on the other stuff. I just don't want to have to fiddle with the .js -> .ts rename stuff causing a merge conflict. There is no way to automatically resolve that, so PR that would do that would be super helpful. |
@cjbarth please check the PR