Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exports C14nCanonicalization, ExclusiveCanonicalization #336

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

cjbarth
Copy link
Contributor

@cjbarth cjbarth commented Jul 8, 2023

Same changes as #335 on to master.

@cjbarth cjbarth marked this pull request as ready for review July 8, 2023 19:12
@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Merging #336 (01242f2) into master (ec309ec) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #336   +/-   ##
=======================================
  Coverage   82.88%   82.88%           
=======================================
  Files           7        7           
  Lines         777      777           
=======================================
  Hits          644      644           
  Misses        133      133           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cjbarth
Copy link
Contributor Author

cjbarth commented Jul 8, 2023

@angeljqv can you lint this and then we can merge it? npm run prettier-format

Copy link
Collaborator

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angeljqv - please run npm run lint:fix on your code to make your code acceptable, so that our automated tests pass

@cjbarth cjbarth merged commit 42aea90 into node-saml:master Jul 10, 2023
@angeljqv angeljqv deleted the patch-2 branch July 10, 2023 13:54
@parallels999
Copy link
Contributor

hi @cjbarth, this PRs has no effect on v4

@cjbarth
Copy link
Contributor Author

cjbarth commented Jul 24, 2023

@parallels999 , are you identifying a problem or concern? I don't understand the nature of your comment.

@parallels999
Copy link
Contributor

xml-crypto/CHANGELOG.md

Lines 23 to 25 in 6e6a8b0

### 🚀 Minor Changes
- [**enhancement**] Exports C14nCanonicalization, ExclusiveCanonicalization [#336](https://github.com/node-saml/xml-crypto/pull/336)

Just concern, i am reading v4 changelog, and this is not available in v4, but it works in v3

@cjbarth
Copy link
Contributor Author

cjbarth commented Jul 24, 2023

That is an oversight (or bad merge) then, sorry about that. Feel free to put up a PR against master again and I'll merge it in and do a 4.1 release (adding a feature). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants