Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some refactoring steps #81

Open
3 of 12 tasks
SimonFischer04 opened this issue May 15, 2023 · 7 comments
Open
3 of 12 tasks

some refactoring steps #81

SimonFischer04 opened this issue May 15, 2023 · 7 comments

Comments

@SimonFischer04
Copy link
Contributor

SimonFischer04 commented May 15, 2023

This project got some get some refactoring.
Here a list of things I found during my recent development of ES-Module port (see: #78 and #79):

Just a list to have them collected and address whenever fits, not necessary to "fix" straight away.

I intend this issue to stay open for quite some time at least and be updated with any new ideas / suggestions, so feel free to comment.

@SimonFischer04
Copy link
Contributor Author

Probably should add node 18 to ci-test, because nodecg recommends v18?

should be as simple as changing "node-version: [16.x]" to "node-version: [16.x, 18.x]"?

@SimonFischer04
Copy link
Contributor Author

when enabling it, I would recommend to set it to only run once a month for example, because by default it spams quite a lot arguably and therefore makes it more annoying than helpful

@SimonFischer04
Copy link
Contributor Author

just found that linting should probably be disabled on the Changelog (and readme) too, because the release / changelog action creates automatic falsely linted file.
Actually, could also just do linting on .ts and .js files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@SimonFischer04 and others