Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies / convert to ES-Modules #79

Merged
merged 3 commits into from
May 15, 2023
Merged

Update dependencies / convert to ES-Modules #79

merged 3 commits into from
May 15, 2023

Conversation

SimonFischer04
Copy link
Contributor

@SimonFischer04 SimonFischer04 commented May 14, 2023

Resolves: #78

@SimonFischer04 SimonFischer04 changed the title Update dependencies / convert to ES-Modules. Resolves: #78 Update dependencies / convert to ES-Modules May 14, 2023
@SimonFischer04
Copy link
Contributor Author

INFO: still trying to figure out what the hell is wrong with the windows build...

@SimonFischer04
Copy link
Contributor Author

So after struggling with this more: unfortunately I was not able to fix it.

The problem on Windows is that the prompts get stuck during testing (but work when running the generator myself!)
There seem to be quite some issues around surrounding this. For example: yeoman/yeoman-test#43,
SBoudrias/Inquirer.js#767.
Some of them might suggest it was (partially for one version) fixed? I mean, yes, running the generator works, but something is broken during the mocha testing environment.
To be honest. Looking through all of this over the last few hours, I don't how it every worked. maybe some very specific combination of dependencies that somehow worked.

Ideas on how to continue:
a) obviously: somehow fix it - but how???
b) support generation using arguments and not run the prompts on windows?:
c) ...

b) Why I would be fine with this option (would this also be acceptable for you?):

  1. Checking if this generator prompts correctly would still be done by linux and mac test. It should be yeoman-test's responsibility to check cross-plattform compatibility of this .withPrompts() function
  2. everything of Generator (except prompt) is still beeing tested on Windows.
  3. as least resort user could always use command line options to generate, if for some reason it broke anyways (however thats possible)

c) Feel free to comment any other ideas / suggestions / ...
Best would of course be that i missed something obvious and someone can get it to work 🙂.

@SimonFischer04
Copy link
Contributor Author

I was not able to fix it.

I will probably still do some more testing tomorrow. Just wanted to give an update here and ask for suggestions.

@SimonFischer04
Copy link
Contributor Author

just tested with bash, still not working, unfortunately.

So i guess I'm fine with just disabling the windows test for now.
(Although I may add argument support anyways sometime, because this would allow better integration into other tools - but then in another PR)

@SimonFischer04
Copy link
Contributor Author

sorry, accidentally leaked my testing into master branch, reverted it

@SimonFischer04
Copy link
Contributor Author

I would be done with testing / changes from my side.

Anything else required?

@Abrahamic-God Abrahamic-God merged commit 6094f90 into nodecg:master May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependencies / convert to ES-Modules
1 participant