Feat/buildtest #83
Merged
Feat/buildtest #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dle to prevent this in the future
|
Ok, apparently everything works fine here and this is just a weird issue on my fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now to this actual issue that lead me to this refactoring ;).
Resolves: #82 and in the process add a test that should prevent something like this in the future by adding a test that actually tries to build the typescript bundle.
And also addresses some parts of: #81. Namely:
Why draft: I still need to investigate why on my testing PR (SimonFischer04#3) now some other test randomly times out on MacOS node16, without changing anything.