Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm update for 0.12 #143

Closed
rvagg opened this issue Oct 5, 2016 · 11 comments
Closed

npm update for 0.12 #143

rvagg opened this issue Oct 5, 2016 · 11 comments

Comments

@rvagg
Copy link
Member

rvagg commented Oct 5, 2016

As per nodejs/node#8928, thanks to @ChALkeR for the ping. The LICENSE is finally updated in npm@2, it might be appropriate for us to ship this in both 0.10 and 0.12 since we're still shipping the old, problematic license. Thoughts @nodejs/lts?

@jasnell
Copy link
Member

jasnell commented Oct 6, 2016

We certainly could. Is that by itself enough to justify a new release of v0.10 tho?

@mhdawson
Copy link
Member

mhdawson commented Oct 7, 2016

I'm not sure its worth it for 0.10.X. Its been the way it is for a long time and 0.10.x should only be in use for a few more weeks.

@rvagg
Copy link
Member Author

rvagg commented Oct 15, 2016

should only be in use for a few more weeks

screenshot 2016-10-13 11 05 10

That's 0.10 in the blue there not doing a very good job at dying, unlike 0.12.

It's going to be used a lot longer than that, particularly given that it's included in some Linux distros that will live for a long time. I'd argue that getting a release out with a correct license is the responsible thing to do with a release line that folks are already having a hard time considering giving up on.

@rvagg
Copy link
Member Author

rvagg commented Oct 15, 2016

screenshot 2016-10-15 15 46 20

Labelled version cause I realise there's more interesting stuff in here for folks.

@MylesBorins
Copy link
Contributor

I'd be up for putting together a 0.10 and 0.12 release including the npm
update and the cares patch

On Sat, Oct 15, 2016, 12:47 AM Rod Vagg notifications@github.com wrote:

[image: screenshot 2016-10-15 15 46 20]
https://cloud.githubusercontent.com/assets/495647/19407463/8b5be2cc-92ee-11e6-84f6-813d86171efa.png

Labelled version cause I realise there's more interesting stuff in here
for folks.


You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
#143 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAecV3ix0VIgWrANlPzZ4A86ls2dKJGAks5q0FrDgaJpZM4KOZqc
.

@rvagg
Copy link
Member Author

rvagg commented Oct 15, 2016

@thealphanerd I think we should still stick to our process of not bundling non-trivial and non-build things with security releases so this would actually mean two releases, one for c-ares and one for npm

@MylesBorins
Copy link
Contributor

It was decided on today's call that @Fishrock123 would backport to v0.12 and that we would have a no-op for 0.10

this issue should be closed when the PR is opened, I am going to edit the title to reflect the current state of things

@MylesBorins MylesBorins changed the title npm update for 0.10 and 0.12 npm update for 0.12 Nov 14, 2016
@ErisDS
Copy link

ErisDS commented Nov 14, 2016

Sorry I couldn't be there this time. Can you explain what no-op for 0.10 means?

@Fishrock123
Copy link
Contributor

Fishrock123 commented Nov 14, 2016

0.10 is EOL so we are not going to another release in any official capacity. (with or without updated npm)

@MylesBorins
Copy link
Contributor

@ErisDS yeah, sorry for the poor choice of wording there. We will not be doing another 0.10 release is what I meant to say

@Fishrock123
Copy link
Contributor

Closing, moving to the PR: nodejs/node#9619

Fishrock123 added a commit to Fishrock123/node that referenced this issue Nov 18, 2016
Refs: nodejs/Release#143
PR-URL: nodejs#9619
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
jBarz pushed a commit to ibmruntimes/node that referenced this issue Dec 22, 2016
Refs: nodejs/Release#143
PR-URL: nodejs/node#9619
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants