-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.12 npm@2 update to latest (v2.15.11) #9619
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM tests pass locally
did some manual testing locally and I can't find a fault with this, so lgtm |
@rvagg want me to land it or would you prefer to do it along with the release? |
@Fishrock123 would you mind landing it on v0.12-staging please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber stamp LGTM
Refs: nodejs/Release#143 PR-URL: nodejs#9619 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Landed in 653b462 |
Refs: nodejs/Release#143 PR-URL: nodejs/node#9619 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Checklist
make -j8 test-npm
passesAffected core subsystem(s)
deps, npm
Description of change
See nodejs/Release#143. This is an update to the latest
npm@2
(v2.15.11) for 0.12.x.R=@thealphanerd, @rvagg, also @nodejs/npm if you could verify I did this correctly.