Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: initial version of strategic initiatives #399

Closed
wants to merge 9 commits into from

Conversation

mhdawson
Copy link
Member

I have likely missed some and included some which are not appropriate. But a first cut to trigger discussion

@nodejs/tsc

Related to #390 and #278

@mhdawson
Copy link
Member Author

If/when we agree to land this will also add link on README.md

@MylesBorins
Copy link
Contributor

MylesBorins commented Oct 26, 2017 via email

| N-API | Michael Dawson | https://github.com/nodejs/abi-stable-node |
| OpenSSL Evolution | Rod Vagg | https://github.com/nodejs/TSC/issues/364 |
| Workers | Anna Henningson | https://github.com/nodejs/worker |
| Error Messages | James Snell | https://github.com/nodejs/node/issues/11273i |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit: 11273i -> 11273

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not?

| CVE Management | Michael Dawson | https://github.com/nodejs/security-wg/issues/33 |
| Core Promise APIs | James Snell | |
| TSC Governance | Myles Borins | https://github.com/nodejs/TSC/issues/383 |
| New Streams APIs | James Snell | https://github.com/ nodejs/node#16414 |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit: https://github.com/ nodejs/node#16414 -> https://github.com/nodejs/node/pull/16414 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space is fixed, but the URL is still wrong?

if the update is `nothing new`) as a way to ensure they are active
and have the support needed.

# Current Intiatives

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit: Intiatives -> Initiatives

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not?

| Core Promise APIs | James Snell | |
| TSC Governance | Myles Borins | https://github.com/nodejs/TSC/issues/383 |
| New Streams APIs | James Snell | https://github.com/ nodejs/node#16414 |
| Diagnotics | Michael Dawson | Happy to have other volunteers but will work to restart |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit: Diagnotics -> Diagnostics

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not?

# Strategic Initiatives

At any one time the Node.js project has a number of strategic initiatives
underway. The goal of the TSC is to have a `champion` for each of these
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: I think we should avoid using backticks for things that aren't (code) keywords. Perhaps use italics, bold, or quotes instead (here and elsewhere in this document).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

....Or use nothing. The word champion does not need the scare quotes here or any other typographic addition.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok changed to remove backticks.

| Diagnotics | Michael Dawson | Happy to have other volunteers but will work to restart |
| Moderation | Rich Trot | |
| Async Hooks | Trevor Norris | |
| V8 Currency | MichaëZasso | |
Copy link
Member

@Trott Trott Oct 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Michaël Zasso

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will try, the special characters always mess me up.

@Trott
Copy link
Member

Trott commented Oct 27, 2017

I don't know if they're strategic, but if so, you can put me down for collaborator onboarding and new contributor onramp.

@Trott
Copy link
Member

Trott commented Oct 27, 2017

Joyee for automation? Rod for build/CI?

@joyeecheung
Copy link
Member

@Trott

Joyee for automation? Rod for build/CI?

Sure!

| Automation       | Joyee Cheung   |  https://github.com/nodejs/automation   |

@mhdawson
Copy link
Member Author

In terms of build/automation I was not quite sure whether we should add areas covered by Working Groups. I'm happy to add those as well if people think that makes sense. Would include Build, Benchmarking, Release etc...

@mhdawson
Copy link
Member Author

@MylesBorins I agree adding to node core readme probably also makes sense for visibility. I'll submit a PR to do that as well once this one lands.

@mhdawson
Copy link
Member Author

@Trott any chance you can push a commit to fix M Zasso's name. I tried my usual tricks of copying from other docs but did not work...

@mhdawson
Copy link
Member Author

Went ahead an added the WG's as well so people can see how it looks

@mhdawson
Copy link
Member Author

@vsemozhetbyt @mscdex @Trott pushed commits to address comments.

@mhdawson
Copy link
Member Author

@MylesBorins added commit to add reference in README.md for TSC. Once this lands will open PR to do the same in the core node repo.

@MylesBorins
Copy link
Contributor

Great work on this @mhdawson

I'd like to suggest that we keep the scope of initiatives to projects as opposed to working groups themselves. For example, James' work on a new lower level streams implementation is a much tighter scope than streams wg.

I would also like to suggest that we keep the number of initiatives that we are working on small and encourage individuals to add their initiatives. If people are not openly taking responsibility for an initiative in this thread it likely should not be included.

There are likely opportunities for the champion to not be a member of the TSC, we might want to account for that. A redesign of the nodejs.org website may be an example of that.

I've marked this for the agenda, we should discuss it on Wednesday

@mhdawson
Copy link
Member Author

I'm in agreement that it is best to omit WG's for now. Will remove and we can disuss further in the meeting

@mhdawson
Copy link
Member Author

mhdawson commented Nov 8, 2017

I'd proposed that people suggest what they think the list should be (or specific additions/removals from the list above). In the absence of any other concrete suggestions we could just start with the current list so that we don't stall out for too long as there has not been much discussion over the last week (I do know people have been busy though)

@Fishrock123
Copy link
Contributor

I would suggest swapping @jasnell on the Streams API work for myself. He's already got a lot of things to champion and I both don't mind taking this one and have kinda been doing that role to begin with-ish?

@Fishrock123
Copy link
Contributor

Well?

| CVE Management | Michael Dawson | https://github.com/nodejs/security-wg/issues/33 |
| Core Promise APIs | James Snell | |
| TSC Governance | Myles Borins | https://github.com/nodejs/TSC/issues/383 |
| New Streams APIs | James Snell | https://github.com/nodejs/node/pull/16414 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be @Fishrock123 instead of @jasnell?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fishrock123 and @jasnell ... we're both working two different sides of this.

@fhinkel
Copy link
Member

fhinkel commented Nov 15, 2017

LGTM with the change for Streams API.

Should this doc include a list of past initiatives? If so, I'd like to add myself for fixing the vm module 😊

@MylesBorins
Copy link
Contributor

I think we should drop diagnostics + automation. If there are specific initiatives within those groups (such as a commit queue or specific diagnostics efforts) those would make sense to include

Collab onboarding + collab on ramp seem like a single initiative to me, thoughts @Trott

@Trott
Copy link
Member

Trott commented Nov 15, 2017

Collab onboarding + collab on ramp seem like a single initiative to me, thoughts @Trott

Sure. We can always split them up later if we need to.

@Fishrock123
Copy link
Contributor

Removing from the agenda as there is no progress to discuss.

@Fishrock123
Copy link
Contributor

Fwiw, we went over these live and got updates on each in the TSC meeting for #418 which can be found in the last half of https://youtu.be/eSgqJg7pu_M

@mhdawson
Copy link
Member Author

Pushed update to address comments. @fhinkel can you give me a link to add for the vm link.

@Fishrock123 can you give me a link to add for the streams 2? From what I can tell from the discussion they are really 2 different initiatives so listing them separately is what I was thinking makes sense.

Once I get those 2 I'll land and we can iterate as we move forward.

@fhinkel
Copy link
Member

fhinkel commented Nov 17, 2017

@mhdawson Here's the link to the commit that fixed most of the vm issues: #399

Can you add a current initiative, please:
Initiative: C++ smart pointers
Champion: Franziska Hinkelmann
Links: https://github.com/nodejs/node/blob/master/CPP_STYLE_GUIDE.md#ownership-and-smart-pointers

@jasnell
Copy link
Member

jasnell commented Nov 17, 2017

@mhdawson ... re: streams, they are not two different initiatives... there are just two sides to one initiative.. that is, reworking streams on both the C++ and JS side.

@mhdawson
Copy link
Member Author

@fhinkel the the first link seems to be for this PR as opposed to the vm issues.

@mhdawson
Copy link
Member Author

@fhinkel is the initiative to move to using smart pointers or something else ?

@mhdawson
Copy link
Member Author

@fhinkel I hope you don't mind but I'm going to go ahead and land, can you submit a Pr to add the new initiative and add the missing link for the past vm initiative ? Alternatively if you send me that info I can open a new PR to update for that.

mhdawson added a commit that referenced this pull request Nov 17, 2017
PR-URL: #399
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@mhdawson
Copy link
Member Author

Landed as cf87134

@mhdawson mhdawson closed this Nov 17, 2017
@mhdawson
Copy link
Member Author

See I missed removing one line, opening a PR to fix.

@mhdawson mhdawson deleted the initiatives branch August 14, 2019 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants