Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Machines updated: Update linux s390 gcc #1735

Merged
merged 6 commits into from
Apr 11, 2019
Merged

Machines updated: Update linux s390 gcc #1735

merged 6 commits into from
Apr 11, 2019

Conversation

sam-github
Copy link
Contributor

@refack
Copy link
Contributor

refack commented Mar 20, 2019

@mhdawson
Copy link
Member

mhdawson commented Mar 20, 2019

@refack not sure how Fedora relates here. We use RHEL 7.X to build for s390.... EDIT, I take that back given that Fedora rpms might be usable on RHEL.

break the gcc dependency builds into individual steps, so they don't have to
be executed as a monolith, and so that gcc-6.x can use the dependencies

Add missing required packages: git is required generally, and zip/unzip are
required by some of the configure scripts for the dependencies.
@mhdawson mhdawson changed the title Update linux s390 gcc DO NOT LAND UNTIL Machines updated: Update linux s390 gcc Apr 4, 2019
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ansible docs were incomplete from the point of view of someone who is
_not_ a nodejs/build WG member with full secrets and access, but who is
trying to setup a machine so it can be a Jenkins worker.
@sam-github
Copy link
Contributor Author

sam-github commented Apr 9, 2019

I updated -3 last week, I updated -2 yesterday, and restarted jenkins today.

I'm updating -1 today.

EDIT: once everything is updated and restared, gcc 6.3 will be on all the systems, and this PR with its select-compiler.sh update can land.

@mhdawson
Copy link
Member

mhdawson commented Apr 9, 2019

@sam-github just remember I also have to update the release machine first. If things look good on -1 today I can do that tomorrow.

@mhdawson
Copy link
Member

Took a while as we had to fix package dependencies on the release machine before ansible ran, but its complete now. Kicked off builds against 12.x, 10.x, 8.x and 6.x and we'll do a sniff test on them due to the dependency fixup we had to do.

We should be able to land this soon.

@sam-github
Copy link
Contributor Author

We've updated all test and release machines to have gcc6, so this can land (and switch to using gcc6 for > 11.x)

@mhdawson mhdawson changed the title DO NOT LAND UNTIL Machines updated: Update linux s390 gcc Machines updated: Update linux s390 gcc Apr 11, 2019
@mhdawson mhdawson merged commit 2b17715 into nodejs:master Apr 11, 2019
@mhdawson
Copy link
Member

Landed as 2b17715

@sam-github sam-github deleted the update-linux-s390-gcc branch April 11, 2019 22:42
@rvagg rvagg mentioned this pull request Apr 16, 2019
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants