This repository has been archived by the owner on Jul 6, 2018. It is now read-only.
http2: fix res.setHeader to update linkedlist APIs #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code change looks good but I'll need to take a look at the test a bit more. |
Closed
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
yosuke-furukawa
force-pushed
the
fix_test_set_header_http2
branch
from
ebb3157
to
608dc75
Compare
|
I changed test code |
jasnell
pushed a commit
that referenced
this pull request
May 7, 2017
PR-URL: #75 Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed! |
jasnell
pushed a commit
that referenced
this pull request
May 19, 2017
PR-URL: #75 Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
May 31, 2017
PR-URL: #75 Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
to jasnell/http2-1
that referenced
this pull request
Jun 22, 2017
PR-URL: nodejs#75 Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
to jasnell/http2-1
that referenced
this pull request
Jul 10, 2017
PR-URL: nodejs#75 Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
to jasnell/http2-1
that referenced
this pull request
Jul 14, 2017
PR-URL: nodejs#75 Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
res.setHeaderto create some patch for removed linkedlist APIs.After this commit, linkedlist APIs are changed. nodejs/node#11726
I just check
res.setHeaderAPI to create some tests.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http2