Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use deprecated v8::Template::Set() in SetMethod #561

Closed
wants to merge 1 commit into from

Conversation

mcollina
Copy link
Member

Same as #560, but for SetMethod.

I think it's ok for releasing this as 2.3.1.

cc @kkoopa @bnoordhuis

@kkoopa
Copy link
Collaborator

kkoopa commented Apr 27, 2016

Thanks for reporting, but Nan::SetMethod is supposed to do what node::NODE_SET_METHOD does. This would not work on a v8::Object, so I instead went with adding an overload in a90951e.

@kkoopa kkoopa closed this Apr 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants