Always uses build in node_api.cc and node_api.h files #139
Assignees
Comments
|
@gabrielschulhof I think we discussed in the last N-API weekly meeting that you were going to investigate this one. |
|
@gabrielschulhof I think you may have landed some changes to address this, are there still more to come ? |
gabrielschulhof
pushed a commit
to gabrielschulhof/node-addon-api
that referenced
this issue
Oct 3, 2017
node_api.h must be included from the normal node include path when we can use the built-in API. The variable needsFlag must be true from version 8.0.0 inclusive until version 8.6.0 non-inclusive. Fixes: nodejs#139
gabrielschulhof
pushed a commit
to gabrielschulhof/node-addon-api
that referenced
this issue
Nov 2, 2017
node_api.h must be included from the normal node include path when we can use the built-in API. The variable needsFlag must be true from version 8.0.0 inclusive until version 8.6.0 non-inclusive. Fixes: nodejs#139
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this issue
Aug 24, 2022
node_api.h must be included from the normal node include path when we can use the built-in API. The variable needsFlag must be true from version 8.0.0 inclusive until version 8.6.0 non-inclusive. PR-URL: nodejs/node-addon-api#152 Fixes: nodejs/node-addon-api#139 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this issue
Aug 26, 2022
node_api.h must be included from the normal node include path when we can use the built-in API. The variable needsFlag must be true from version 8.0.0 inclusive until version 8.6.0 non-inclusive. PR-URL: nodejs/node-addon-api#152 Fixes: nodejs/node-addon-api#139 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this issue
Sep 19, 2022
node_api.h must be included from the normal node include path when we can use the built-in API. The variable needsFlag must be true from version 8.0.0 inclusive until version 8.6.0 non-inclusive. PR-URL: nodejs/node-addon-api#152 Fixes: nodejs/node-addon-api#139 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this issue
Aug 11, 2023
node_api.h must be included from the normal node include path when we can use the built-in API. The variable needsFlag must be true from version 8.0.0 inclusive until version 8.6.0 non-inclusive. PR-URL: nodejs/node-addon-api#152 Fixes: nodejs/node-addon-api#139 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It looks to me like the wrapper is always building off the copies of the node_api.cc and node_api.h files which are in this project, as opposed to using node_api.h which comes from a node install...
Just want to discuss to confirm we believe that is the right thing to be doing.
The text was updated successfully, but these errors were encountered: