Clean up include path and flag-check #152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I couldn't test this with versions of node other than 8.6.0, because node-addon-api doesn't currently build on those versions (#142). |
|
I tried this with 8.6 (binary distro from nodejs.org) and get this error: Without the change in this PR, the test build ok. |
|
@gabrielschulhof am I doing something wrong ? |
|
@gabrielschulhof ping. |
node_api.h must be included from the normal node include path when we can use the built-in API. The variable needsFlag must be true from version 8.0.0 inclusive until version 8.6.0 non-inclusive. Fixes: nodejs#139
gabrielschulhof
force-pushed
the
fix-include
branch
from
09bca93
to
794e3f5
Compare
|
@mhdawson all fixed now. |
|
@gabrielschulhof thanks, landing now. |
|
Landed as 5a5920a |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
node_api.h must be included from the normal node include path when we can use the built-in API. The variable needsFlag must be true from version 8.0.0 inclusive until version 8.6.0 non-inclusive. PR-URL: nodejs/node-addon-api#152 Fixes: nodejs/node-addon-api#139 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
node_api.h must be included from the normal node include path when we can use the built-in API. The variable needsFlag must be true from version 8.0.0 inclusive until version 8.6.0 non-inclusive. PR-URL: nodejs/node-addon-api#152 Fixes: nodejs/node-addon-api#139 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
node_api.h must be included from the normal node include path when we can use the built-in API. The variable needsFlag must be true from version 8.0.0 inclusive until version 8.6.0 non-inclusive. PR-URL: nodejs/node-addon-api#152 Fixes: nodejs/node-addon-api#139 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
node_api.h must be included from the normal node include path when we can use the built-in API. The variable needsFlag must be true from version 8.0.0 inclusive until version 8.6.0 non-inclusive. PR-URL: nodejs/node-addon-api#152 Fixes: nodejs/node-addon-api#139 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node_api.h must be included from the normal node include path when
we can use the built-in API.
The variable needsFlag must be true from version 8.0.0 inclusive until
version 8.6.0 non-inclusive.
Fixes: #139