net: unref() is not persistent

[bnoordhuis]

var net = require('net');
var server = net.createServer();
server.unref();
server.listen();
net.connect(server.address().port).unref();

It hangs because of the unref() that comes before listen() and the one after connect(). In that vein:

require('net').connect(42).unref();

It fails with ECONNREFUSED because the unref() is a no-op. The expected behavior for both scripts is that they simply quit. Affects v0.10 and master.

The documentation doesn't mention when it's okay to call unref(). For the sake of user friendliness, net.Socket and net.Server should remember the ref state and retroactively apply it when the handle is created. Probably applies to other handle types as well.

[tjfontaine]

Right this is definitely a bug that should be squashed. Assigned to me.

[cjihrig]

nodejs/node@85d9983 just landed. It can either be ported, or we can close this and pick up the changes in the converged branch.