This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
net: make Server.prototype.unref() persistent #8966
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
unref()
method does not remember any state if called before the server's handle has been created. This commit adds state to track calls toref()
andunref()
.Related to #7077. Note - a similar fix is possible for
Socket.prototype.unref()
(which I have code for). However,Socket
appears to have additionalunref()
issues other than persistence.