Skip to content

Commit

Permalink
build,win: silence MSVC warning C4129 for V8
Browse files Browse the repository at this point in the history
Currently we get 13,799 of those per build

PR-URL: #27017
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
  • Loading branch information
refack authored and BethGriggs committed Apr 9, 2019
1 parent ea47189 commit b64b223
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions deps/v8/gypfiles/toolchain.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -1395,6 +1395,7 @@
}, # configurations
'cflags': [ '-Wno-type-limits', ],
'msvs_disabled_warnings': [
4129, # unrecognized character escape sequence (torque-generated)
4245, # Conversion with signed/unsigned mismatch.
4267, # Conversion with possible loss of data.
4324, # Padding structure due to alignment.
Expand Down

0 comments on commit b64b223

Please sign in to comment.