Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build,win: silence MSVC warning C4129 for V8 #27017

Merged
merged 1 commit into from
Mar 31, 2019
Merged

build,win: silence MSVC warning C4129 for V8 #27017

merged 1 commit into from
Mar 31, 2019

Conversation

refack
Copy link
Contributor

@refack refack commented Mar 30, 2019

Currently we get 13,799 of those per build

/CC @nodejs/build-files @nodejs/v8-update

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/3111/pipeline

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 30, 2019
@refack refack added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. labels Mar 30, 2019
@refack refack self-assigned this Mar 30, 2019
@refack refack added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 30, 2019
@refack
Copy link
Contributor Author

refack commented Mar 30, 2019 •
edited
Loading

Windows-CI: https://ci.nodejs.org/job/node-test-commit-windows-fanned/26038 ✔️

If this passes, please 👍 for fast tracking since this kinda makes the console output usable again.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 31, 2019
@refack
build,win: silence MSVC warning C4129 for V8
d379e45 
Currently we get 13,799 of those per build

PR-URL: nodejs#27017
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@refack refack merged commit d379e45 into nodejs:master Mar 31, 2019
@refack refack deleted the silence-msvc-C4129-for-V8 branch March 31, 2019 13:43
@refack refack mentioned this pull request Mar 31, 2019
Closed
BethGriggs pushed a commit that referenced this pull request Apr 5, 2019
@refack @BethGriggs
build,win: silence MSVC warning C4129 for V8
f682852 
Currently we get 13,799 of those per build

PR-URL: #27017
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs pushed a commit that referenced this pull request Apr 9, 2019
@refack @BethGriggs
build,win: silence MSVC warning C4129 for V8
0dd5d3a 
Currently we get 13,799 of those per build

PR-URL: #27017
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs pushed a commit that referenced this pull request Apr 9, 2019
@refack @BethGriggs
build,win: silence MSVC warning C4129 for V8
b64b223 
Currently we get 13,799 of those per build

PR-URL: #27017
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Apr 9, 2019
Merged
@refack refack removed their assignment Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@refack @nodejs-github-bot @cjihrig @richardlau @BridgeAR