tls: permit null as a cipher value

Allow null along with undefined for cipher value. Fixes: #36292 PR-URL: #36318 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
nodejs · Dec 7, 2020 · f317bba · f317bba
1 parent 29b5236
commit f317bba
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/lib/_tls_common.js b/lib/_tls_common.js
@@ -263,7 +263,7 @@ exports.createSecureContext = function createSecureContext(options) {
     }
   }
 
-  if (ciphers !== undefined)
+  if (ciphers != null)
     validateString(ciphers, 'options.ciphers');
 
   // Work around an OpenSSL API quirk. cipherList is for TLSv1.2 and below,

diff --git a/test/parallel/test-tls-set-ciphers.js b/test/parallel/test-tls-set-ciphers.js
@@ -104,3 +104,7 @@ test('AES256-SHA', ':', U, U, 'ERR_INVALID_ARG_VALUE');
 // Using '' is synonymous for "use default ciphers"
 test('TLS_AES_256_GCM_SHA384', '', 'TLS_AES_256_GCM_SHA384');
 test('', 'TLS_AES_256_GCM_SHA384', 'TLS_AES_256_GCM_SHA384');
+
+// Using null should be treated the same as undefined.
+test(null, 'AES256-SHA', 'AES256-SHA');
+test('AES256-SHA', null, 'AES256-SHA');