Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: permit null as a cipher value #36318

Closed
wants to merge 1 commit into from
Closed

tls: permit null as a cipher value #36318

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 29, 2020

Allow null along with undefined for cipher value.

Fixes: #36292

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tls Issues and PRs related to the tls subsystem. label Nov 29, 2020
@Trott Trott mentioned this pull request Nov 29, 2020
Closed
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34619/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34623/

@Trott
tls: permit null as a cipher value
4a741b8 
Allow null along with undefined for cipher value.

Fixes: nodejs#36292

PR-URL: nodejs#36318
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@Trott
Copy link
Member Author

Trott commented Dec 2, 2020

Landed in 4a741b8

@Trott Trott closed this Dec 2, 2020
@Trott Trott deleted the cipher-fix branch December 2, 2020 14:11
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
@Trott @danielleadams
tls: permit null as a cipher value
f317bba 
Allow null along with undefined for cipher value.

Fixes: #36292

PR-URL: #36318
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
Merged
cjihrig pushed a commit to cjihrig/node that referenced this pull request Dec 8, 2020
@Trott @cjihrig
tls: permit null as a cipher value
b426892 
Allow null along with undefined for cipher value.

Fixes: nodejs#36292

PR-URL: nodejs#36318
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tls.connect() options ciphers no longer accept null as a valid value in node v15.3.0
8 participants
@Trott @nodejs-github-bot @jasnell @benjamingr @lpinca @cjihrig @tniessen @targos