Skip to content

Commit

Permalink
src: make env_ and context_ private
Browse files Browse the repository at this point in the history
This commit makes the currently protected members env_ and context_
private in node_contextify.h.

PR-URL: #20671
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
danbev committed May 14, 2018
1 parent f22c7c1 commit fcf2e42
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions src/node_contextify.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,6 @@ struct ContextOptions {
};

class ContextifyContext {
protected:
Environment* const env_;
Persistent<v8::Context> context_;

public:
ContextifyContext(Environment* env,
v8::Local<v8::Object> sandbox_obj,
Expand Down Expand Up @@ -97,6 +93,8 @@ class ContextifyContext {
static void IndexedPropertyDeleterCallback(
uint32_t index,
const v8::PropertyCallbackInfo<v8::Boolean>& args);
Environment* const env_;
Persistent<v8::Context> context_;
};

} // namespace contextify
Expand Down

0 comments on commit fcf2e42

Please sign in to comment.