Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: make env_ and context_ private #20671

Closed
wants to merge 1 commit into from
Closed

src: make env_ and context_ private #20671

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented May 11, 2018

This commit makes the currently protected members env_ and context_
private in node_contextify.h.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@danbev
src: make env_ and context_ private
8187a7a 
This commit makes the currently protected members env_ and context_
private in node_contextify.h.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. vm Issues and PRs related to the vm subsystem. labels May 11, 2018
@danbev
Copy link
Contributor Author

danbev commented May 11, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/14808/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 11, 2018
@danbev
Copy link
Contributor Author

danbev commented May 14, 2018

Landed in fcf2e42.

@danbev danbev closed this May 14, 2018
@danbev danbev deleted the contextify_remove_protected_members branch May 14, 2018 03:58
danbev added a commit that referenced this pull request May 14, 2018
@danbev
src: make env_ and context_ private
fcf2e42 
This commit makes the currently protected members env_ and context_
private in node_contextify.h.

PR-URL: #20671
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request May 14, 2018
@danbev @addaleax
src: make env_ and context_ private
30aceed 
This commit makes the currently protected members env_ and context_
private in node_contextify.h.

PR-URL: #20671
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax addaleax mentioned this pull request May 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@danbev @jasnell @addaleax @TimothyGu @cjihrig @tniessen @nodejs-github-bot