Windows - inspector - intermittent ? - inspector/test-bindings #15558

mhdawson · 2017-09-22T14:56:08Z

Failure during run on un-related PR

Version: master
Platform: windows
Subsystem: inspector

https://ci.nodejs.org/job/node-test-binary-windows/11280/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=1/console

not ok 441 inspector/test-bindings
  ---
  duration_ms: 0.227
  severity: crashed
  stack: |-
    oh no!
    exit code: CRASHED
  ...

The text was updated successfully, but these errors were encountered:

mhdawson · 2017-09-22T14:56:37Z

@nodejs/platform-windows

joaocgreis · 2017-09-22T16:22:55Z

Looking at https://ci.nodejs.org/view/All/job/node-daily-master/ , this has happened for 3 days (since September 20).

There's also `inspector/test-debug-end`.

https://ci.nodejs.org/job/node-test-binary-windows/11275/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=1/console

not ok 442 inspector/test-debug-end
  ---
  duration_ms: 0.696
  severity: fail
  stack: |-
    Test there's no crash stopping server that was not started
    Test there's no crash stopping server without connecting
    [err] Debugger listening on ws://127.0.0.1:63103/542e4e93-0081-41fd-a597-bf147ce898b0
    [err] For help see https://nodejs.org/en/docs/inspector
    [err] 
    Test there's no crash stopping server after connecting
    [test] Connecting to a child Node process
    [test] Testing /json/list
    [err] Debugger listening on ws://127.0.0.1:63104/cc5fdd8a-9fb6-4229-853f-3361070018df
    [err] For help see https://nodejs.org/en/docs/inspector
    [err] 
    [err] Debugger attached.
    [err] Debugger listening on ws://127.0.0.1:63107/ede6f417-c23f-44e3-8f61-292d613b1dde
    [err] For help see https://nodejs.org/en/docs/inspector
    [err] 
    { AssertionError [ERR_ASSERTION]: 42 === 3221225477
        at testSessionNoCrash (c:\workspace\node-test-binary-windows\COMPILED_BY\vs2017\RUNNER\win2016\RUN_SUBSET\1\test\inspector\test-debug-end.js:35:3)
        at <anonymous>
        at process._tickCallback (internal/process/next_tick.js:188:7)
      generatedMessage: true,
      name: 'AssertionError [ERR_ASSERTION]',
      code: 'ERR_ASSERTION',
      actual: 42,
      expected: 3221225477,
      operator: '===' }
    1

cc @nodejs/testing and @eugeneo perhaps

BridgeAR · 2017-09-24T17:57:32Z

Here is another stack trace

not ok 441 inspector/test-bindings
  ---
  duration_ms: 0.234
  severity: fail
  stack: |-
    Expecting warning to be emitted
    (node:5800) Error: We expect this
    c:\workspace\node-test-binary-windows\COMPILED_BY\vs2017\RUNNER\win2016\RUN_SUBSET\1\test\common\index.js:789
                 (err) => process.nextTick(() => { throw err; }));
                                                   ^
    
    AssertionError [ERR_ASSERTION]: [ 'Iteration 1 variable: i expected: 1 actual: 0',
      'Iteration 2 variable: i expected: 2 actual: 1',
      'Iteration 2 variable: a deepStrictEqual []
        at testSampleDebugSession (c:\workspace\node-test-binary-windows\COMPILED_BY\vs2017\RUNNER\win2016\RUN_SUBSET\1\test\inspector\test-bindings.js:104:10)
        at doTests (c:\workspace\node-test-binary-windows\COMPILED_BY\vs2017\RUNNER\win2016\RUN_SUBSET\1\test\inspector\test-bindings.js:131:3)
        at <anonymous>
        at process._tickCallback (internal/process/next_tick.js:188:7)
        at Function.Module.runMain (module.js:643:11)
        at startup (bootstrap_node.js:187:16)
        at bootstrap_node.js:607:3
  ...

BridgeAR · 2017-09-24T18:01:17Z

@joaocgreis it is probably a good idea to open a new issue for the other failure?

joaocgreis · 2017-09-25T20:53:44Z

@BridgeAR they started at about the same time in the same subsystem, so they might be related. We can probably address them here until we figure out if they are related or not, but feel free to open another issue if you think that will help.

Trott · 2017-09-26T23:30:23Z

Is anyone actively looking at this? (Saw another one today and I'm looking at CI a lot less than usual, so a good chance there's lots more.) I'm hoping we can get CI reliably green in preparation for Code + Learn next week.

refack · 2017-09-26T23:43:51Z

Is anyone actively looking at this? (Saw another one today and I'm looking at CI a lot less than usual, so a good chance there's lots more.) I'm hoping we can get CI reliably green in preparation for Code + Learn next week.

I'm trying to repro locally.

Trott · 2017-09-28T03:48:08Z

ping @nodejs/v8-inspector Any idea what might be causing these tests to fail on Windows? It would be good to have CI back to green for Code + Learn next week....

eugeneo · 2017-09-29T18:02:56Z

@refack - are you looking into it? I inspected the test case visually and feel like the test may not be deterministic (e.g. it relies on the variables order in the inspector response). I think V8 might shuffle the variables because of reasons (JIT, etc). I'm going to try and make the test more deterministic.

eugeneo · 2017-09-29T18:04:25Z

(Sorry, disregard my comment - does not seem to be the case. I still would like to take a look at this test case)

mhdawson · 2017-09-29T21:41:44Z

Failed again here: https://ci.nodejs.org/job/node-test-binary-windows/11453/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=0/console

eugeneo · 2017-09-29T22:43:21Z

Stress test is unable to reproduce the failure - https://ci.nodejs.org/job/node-stress-single-test/1430/nodes=win2016/console

refack · 2017-09-30T03:05:10Z

@eugeneo I just built a binary with VS2017 that reproduces quite often, which made me think it might be a VS2017 issue. The two jobs mentioned above were also built with VS2017:

/11280/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=1/console
/11453/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=0/console

(I can send you the binary if you need it)

Trott · 2017-09-30T17:05:21Z

More failures today, and yeah, it's vs2017 again.

https://ci.nodejs.org/job/node-test-binary-windows/11473/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=0/console

not ok 446 inspector/test-bindings
  ---
  duration_ms: 0.245
  severity: crashed
  stack: |-
    oh no!
    exit code: CRASHED

Same results in https://ci.nodejs.org/job/node-test-binary-windows/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=0/11473/console

refack · 2017-10-02T17:50:18Z

/11360/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=1/console

Ref: nodejs#15558

PR-URL: #15747 Refs: #15558 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: nodejs/node#15747 Refs: nodejs/node#15558 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

MylesBorins · 2017-10-07T21:09:24Z

Another failure https://ci.nodejs.org/job/node-test-binary-windows/11537/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=3/console

PR-URL: #15747 Refs: #15558 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

ofrobots · 2017-10-25T23:59:08Z

Reopening as I think the flaky tests still need to be marked non-flaky after confirming so.

ofrobots · 2017-10-26T15:29:11Z

Reopening again.

The inspector_agent depends on the context still being accessible during the destructor execution. PR-URL: nodejs/node#16472 Fixes: nodejs/node#15558 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

ofrobots · 2017-10-27T17:06:28Z

Based on the stress test here, there is still flakiness despite #16472.

The inspector_agent depends on the context still being accessible during the destructor execution. PR-URL: #16472 Fixes: #15558 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

eugeneo · 2017-11-22T21:18:06Z

@refack

BTW: did you check that all accesses to libuv are thread safe?

I see this issue using the JS API (e.g. there's no second thread running, libuv is not used for anything). What I am seeing is that session is receiving repeat "Debugger.paused" notifications from the V8. Number of those repetition is same as the total number of the previous sessions + 1. E.g. if I open and close 2 sessions, third session I will be notified thrice.

It does not look like it is in V8 side of the Inspector too - it is a debug listener that fires the event multiple times, Inspector has a single session and properly dispatches the event there.

I suspect there's something funny with some object deregistering, so could it be some destructor is now "optimized out"?

I will update this bug when I have more information.

Trott · 2017-12-04T02:34:03Z

This is now sequential/test-inspector-bindings, right?

https://ci.nodejs.org/job/node-test-binary-windows/13320/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=0/console

not ok 514 sequential/test-inspector-bindings # TODO : Fix flaky test
  ---
  duration_ms: 0.240
  severity: flaky
  stack: |-
    Expecting warning to be emitted
    (node:6608) Error: We expect this
    c:\workspace\node-test-binary-windows\test\common\index.js:797
                 (err) => process.nextTick(() => { throw err; }));
                                                   ^
    
    AssertionError [ERR_ASSERTION]: [ 'Iteration 1 variable: i expected: 1 actual: 0',
      'Iteration 2 variable: i expected: 2 actual: 1',
      'Iteration 2 variable: a deepStrictEqual []
        at testSampleDebugSession (c:\workspace\node-test-binary-windows\test\sequential\test-inspector-bindings.js:104:10)
        at doTests (c:\workspace\node-test-binary-windows\test\sequential\test-inspector-bindings.js:131:3)
        at <anonymous>
        at process._tickCallback (internal/process/next_tick.js:165:7)
        at Function.Module.runMain (module.js:703:11)
        at startup (bootstrap_node.js:195:16)
        at bootstrap_node.js:646:3
  ...

refack · 2017-12-07T18:05:41Z

Still open.

Trott · 2018-10-18T04:18:49Z

It seems like perhaps this should be closed. Feel free to re-open (or leave a comment requesting that it be re-opened) if you disagree. I'm just tidying up and not acting on a super-strong opinion or anything like that.

mhdawson added the windows Issues and PRs related to the Windows platform. label Sep 22, 2017

mhdawson mentioned this issue Sep 22, 2017

n-api: fix warning about size_t compare with int #15508

Closed

4 tasks

mscdex added inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests. labels Sep 22, 2017

refack added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Sep 22, 2017

refack mentioned this issue Sep 23, 2017

[v8.x backport] test,process: run 'abort' suite on Windows #15460

Closed

3 tasks

refack self-assigned this Sep 26, 2017

mhdawson mentioned this issue Sep 29, 2017

n-api: add check for large strings #15611

Closed

3 tasks

cjihrig mentioned this issue Oct 3, 2017

deps: upgrade libuv to 1.15.0 #15745

Merged

2 tasks

joaocgreis added a commit to JaneaSystems/node that referenced this issue Oct 3, 2017

test: mark test-bindings and test-debug-end flaky

6ba3489

Ref: nodejs#15558

joaocgreis mentioned this issue Oct 3, 2017

test: mark test-bindings and test-debug-end flaky #15747

Closed

2 tasks

ofrobots closed this as completed in #16472 Oct 25, 2017

ofrobots reopened this Oct 25, 2017

TimothyGu closed this as completed in TimothyGu/node-no-icu@e3503ac Oct 26, 2017

ofrobots reopened this Oct 26, 2017

refack mentioned this issue Nov 5, 2017

src: use unrefed async for GC tracking #16758

Closed

2 tasks

This was referenced Nov 8, 2017

flake: sequential/test-inspector-stop-profile-after-done #16772

Closed

doc: drop support for VS2015 #16868

Merged

refack mentioned this issue Nov 21, 2017

sequential/test-inspector-port-zero segfaults on macOS 10.10 and below #17175

Closed

eugeneo assigned eugeneo and unassigned refack Nov 22, 2017

eugeneo mentioned this issue Nov 22, 2017

Tips for debugging on Windows? #17253

Closed

addaleax closed this as completed in ayojs/ayo@8edfd0a Dec 7, 2017

refack reopened this Dec 7, 2017

Trott closed this as completed Oct 18, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Windows - inspector - intermittent ? - inspector/test-bindings #15558

Windows - inspector - intermittent ? - inspector/test-bindings #15558

mhdawson commented Sep 22, 2017

mhdawson commented Sep 22, 2017

joaocgreis commented Sep 22, 2017

BridgeAR commented Sep 24, 2017

BridgeAR commented Sep 24, 2017

joaocgreis commented Sep 25, 2017

Trott commented Sep 26, 2017

refack commented Sep 26, 2017

Trott commented Sep 28, 2017

eugeneo commented Sep 29, 2017

eugeneo commented Sep 29, 2017

mhdawson commented Sep 29, 2017

eugeneo commented Sep 29, 2017

refack commented Sep 30, 2017

Trott commented Sep 30, 2017

refack commented Oct 2, 2017

MylesBorins commented Oct 7, 2017 •

edited

Loading

ofrobots commented Oct 25, 2017

ofrobots commented Oct 26, 2017

ofrobots commented Oct 27, 2017

eugeneo commented Nov 22, 2017

Trott commented Dec 4, 2017

refack commented Dec 7, 2017

Trott commented Oct 18, 2018

Windows - inspector - intermittent ? - inspector/test-bindings #15558

Windows - inspector - intermittent ? - inspector/test-bindings #15558

Comments

mhdawson commented Sep 22, 2017

mhdawson commented Sep 22, 2017

joaocgreis commented Sep 22, 2017

BridgeAR commented Sep 24, 2017

BridgeAR commented Sep 24, 2017

joaocgreis commented Sep 25, 2017

Trott commented Sep 26, 2017

refack commented Sep 26, 2017

Trott commented Sep 28, 2017

eugeneo commented Sep 29, 2017

eugeneo commented Sep 29, 2017

mhdawson commented Sep 29, 2017

eugeneo commented Sep 29, 2017

refack commented Sep 30, 2017

Trott commented Sep 30, 2017

refack commented Oct 2, 2017

MylesBorins commented Oct 7, 2017 • edited Loading

ofrobots commented Oct 25, 2017

ofrobots commented Oct 26, 2017

ofrobots commented Oct 27, 2017

eugeneo commented Nov 22, 2017

Trott commented Dec 4, 2017

refack commented Dec 7, 2017

Trott commented Oct 18, 2018

MylesBorins commented Oct 7, 2017 •

edited

Loading