Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x backport] test,process: run 'abort' suite on Windows #15460

Closed
wants to merge 2 commits into from
Closed

[v8.x backport] test,process: run 'abort' suite on Windows #15460

wants to merge 2 commits into from

Conversation

refack
Copy link
Contributor

@refack refack commented Sep 18, 2017 •
edited
Loading

PR-URL: #15056

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test,build

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v8.x windows Issues and PRs related to the Windows platform. labels Sep 18, 2017
@refack refack added the test Issues and PRs related to the tests. label Sep 18, 2017
@refack
Copy link
Contributor Author

refack commented Sep 18, 2017

Windows CI: https://ci.nodejs.org/job/node-test-commit-windows-fanned/11771/

@refack refack mentioned this pull request Sep 18, 2017
Merged
3 tasks
@refack
test,process: run 'abort' suite on Windows
26f2755 
PR-URL: nodejs#15056
Fixes: nodejs#14012
Refs: nodejs#14013
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@refack
use ‭c0000005 errorlevel
62b8410
@refack
Copy link
Contributor Author

refack commented Sep 23, 2017 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-commit/12556/ ✔️
(single windows failure is #15558)

@jasnell
Copy link
Member

jasnell commented Sep 25, 2017

Landed in v8.x-staging

@jasnell jasnell closed this Sep 25, 2017
@refack refack deleted the v8-backport-15056 branch October 24, 2017 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@refack @jasnell @nodejs-github-bot