Tracking Issue: process.binding to internalBinding

[jasnell]

Moving from process.binding() to internalBinding() will be a significant effort. There are hundreds of process.binding() uses inside core and many many userland references. It's going to take a while to convert everything.

TODO

• inspector (this one is quite non-trivial... will require additional thought)

Done

• async_wrap src: move process.binding('async_wrap') internal #22469
• buffer buffer: move process.binding('buffer') to internalBinding #22370
• cares_wrap dns: make process.binding('cares_wrap') internal #22474
• crypto crypto: move process.binding('crypto') to internal #22426
• config src,lib: make process.binding('config') internal #23400
• constants src,lib: move natives and constants to internalBinding() #23663
• contextify vm: move process.binding('contextify') to internalBinding #22419
• fs fs: make process.binding('fs') internal #22478
• fs_event_wrap fs: make fs_event_wrap binding internal #22480
• http2http2: move process.binding('http2') to internalBinding #22328
• http_parser http_parser: move process.binding('http_parser') to internalBinding #22329
• icu icu: make process.binding('icu') internal #23234
• js_stream js_stream: move process.binding('js_stream') to internalBinding #22239
• natives src,lib: move natives and constants to internalBinding() #23663
• os os: move process.binding('os') to internalBinding #25087
• performance src: move process.binding('performance') to internalBinding #22029
• pipe_wrap lib: make pipe_wrap binding internal #22482
• process_wrap child_process: make process_wrap binding internal #22479
• serdes v8: move serdes to internalBinding #22161
• signal_wrap src: move process.binding('signal_wrap') to internalBinding #22290
• spawn_sync spawn_sync: move process.binding('spawn_sync') to internalBinding #22260
• stream_wrap
• tcp_wrap src: move process.binding('tcp_wrap') to internal #22432
• tls_wrap crypto: move process.binding('tls_wrap') internal #22429
• trace_events trace_events: move trace_events to internalBinding #22159
• tty_wrap tty: make process.binding('tty_wrap') internal #22477
• udp_wrap dgram: make process.binding('udp_wrap') internal #22475
• url url: move process.binding('url') to internalBinding #22204
• util util: make util binding internal #22675
• uv uv: move process.binding('uv') to internalBinding #22163
• v8 v8: move process.binding('v8') to internalBinding #22288
• zlib (removing process.binding('zlib') breaks npm) zlib: move process.binding('zlib') to internalBinding #23307

[devsnek]

updated to include all usage of NODE_BUILTIN_MODULE_CONTEXT_AWARE

[jasnell]

I've got uv in progress now

[devsnek]

@ChALkeR would it be possible to get info about the relative usage of all of these? i'm assuming there are some like serdes we can kill right away and others like util that will take longer.

[jasnell]

I tried doing zlib but it broke npm.
I tried doing config but there's a buffer test that isn't feasible if config is moved. Planning to refactor

[maclover7]

Just double checking, should all migration PRs should be marked as semver-major?

[jasnell]

Unfortunately that's likely the best thing.

[jasnell]

For some of this it's likely going to be quite tricky to have a proper migration strategy in place given that moving something over to internalBinding() means that the process.binding() version just stops working. We're going to have to take it very slow and work on migrating the bits with the smallest immediate impact and working up from there.

[pratik0509]

I would also like to contribute here. Can you please give me some heads up?

[jmannanc]

Hey,

I've been trying to move buffer to internalBinding to try and help out and I think I've gotten close but make -j4 test keeps giving these errors: https://hastebin.com/ecucikeraj.cs

You can see the branch that I'm working on here. Any help on maybe how to fix these errors/why they are happening would be very much appreciated 😄. Sorry for the bother if my changes are incorrect or this is not allowed.

[starkwang]

Now the inspector module is the only one left to be converted. Should we open a new issue to track it ? @jasnell

[BeniCheni]

Hi, @starkwang. it appears that #24931 took care of inspector.

[jasnell]

I think we can close this now.