Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dns: make process.binding('cares_wrap') internal #22474

Merged
merged 1 commit into from
Aug 30, 2018
Merged

dns: make process.binding('cares_wrap') internal #22474

merged 1 commit into from
Aug 30, 2018

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Aug 23, 2018

Refs: #22160

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/639/pipeline

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Aug 23, 2018
@jasnell jasnell mentioned this pull request Aug 23, 2018
Closed
33 tasks
@addaleax addaleax added the dns Issues and PRs related to the dns subsystem. label Aug 23, 2018
@jasnell jasnell added the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 23, 2018
@cjihrig
Copy link
Contributor Author

cjihrig commented Aug 27, 2018

This needs to be rebased and a CI run, but first it needs another review from @nodejs/tsc.

@cjihrig
dns: make process.binding('cares_wrap') internal
8b0c482 
PR-URL: nodejs#22474
Refs: nodejs#22160
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@cjihrig
Copy link
Contributor Author

cjihrig commented Aug 30, 2018

Green CI: https://ci.nodejs.org/job/node-test-pull-request/16869/

@cjihrig cjihrig merged commit 8b0c482 into nodejs:master Aug 30, 2018
@cjihrig cjihrig deleted the cares-wrap branch August 30, 2018 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
dns Issues and PRs related to the dns subsystem. lib / src Issues and PRs related to general changes in the lib or src directory. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cjihrig @nodejs-github-bot @danbev @jasnell @addaleax @lpinca @targos @BridgeAR