Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: custom inspect functions ignore depth #27976

Closed
addaleax opened this issue May 30, 2019 · 0 comments · Fixed by #27983
Closed

http2: custom inspect functions ignore depth #27976

addaleax opened this issue May 30, 2019 · 0 comments · Fixed by #27983
Labels
http2 Issues or PRs related to the http2 subsystem. util Issues and PRs related to the built-in util module.

Comments

@addaleax
Copy link
Member

The custom inspect functions for Http2Stream and Http2Session ignore the depth at which the inspect function currently is, leading to more information being printed than what should be printed.
@addaleax addaleax added util Issues and PRs related to the built-in util module. http2 Issues or PRs related to the http2 subsystem. labels May 30, 2019
@cjihrig cjihrig mentioned this issue May 30, 2019
Merged
2 tasks
cjihrig added a commit to cjihrig/node that referenced this issue Jun 1, 2019
@cjihrig
http2: respect inspect() depth
f86100c 
This commit causes Http2Stream and Http2Session to account
for inspect() depth.

PR-URL: nodejs#27983
Fixes: nodejs#27976
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this issue Jun 3, 2019
@cjihrig @targos
http2: respect inspect() depth
799aeca 
This commit causes Http2Stream and Http2Session to account
for inspect() depth.

PR-URL: #27983
Fixes: #27976
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
http2 Issues or PRs related to the http2 subsystem. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

http2: respect inspect() depth cjihrig/node
1 participant
@addaleax