http2: respect inspect() depth #27983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but I have a question. I did read this code and saw |
That syntax is called a computed property/method name. The linked MDN page will do a better job explaining it than I probably will in a GitHub comment. |
timofeichaplinskiy
approved these changes
May 30, 2019
BridgeAR
approved these changes
May 30, 2019
addaleax
approved these changes
May 30, 2019
jasnell
approved these changes
May 31, 2019
trivikr
approved these changes
May 31, 2019
BridgeAR
added
author ready
|
CI: https://ci.nodejs.org/job/node-test-pull-request/23530/ EDIT(cjihrig): CI was yellow. |
This commit causes Http2Stream and Http2Session to account for inspect() depth. PR-URL: nodejs#27983 Fixes: nodejs#27976 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
3 tasks
targos
pushed a commit
that referenced
this pull request
Jun 3, 2019
This commit causes Http2Stream and Http2Session to account for inspect() depth. PR-URL: #27983 Fixes: #27976 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit causes
Http2StreamandHttp2Sessionto account forinspect()depth.Fixes: #27976
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes