Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHANGELOG_V12 - wrong flag listed #29959

Closed
AviVahl opened this issue Oct 14, 2019 · 8 comments
Closed

CHANGELOG_V12 - wrong flag listed #29959

AviVahl opened this issue Oct 14, 2019 · 8 comments
Labels
doc Issues and PRs related to the documentations. source maps Issues and PRs related to source map support.

Comments

@AviVahl
Copy link

AviVahl commented Oct 14, 2019

  • Version:
    Irrelevant.
  • Platform:
    Irrelevant
  • Subsystem:

Release notes for node v12.12.0 say --source-map-support, but trying to use it results in:
node: bad option: --source-map-support

The actual flag is --enable-source-maps.
@Trott
Copy link
Member

Trott commented Oct 14, 2019

@bcoe

@bcoe
Copy link
Contributor

bcoe commented Oct 14, 2019

The flag should be "--enable-source-map", was changed during code review.

@AviVahl
Copy link
Author

AviVahl commented Oct 14, 2019

@bcoe missing the postfix s on purpose? or a typo?

@Trott

This comment has been minimized.

Sign in to view
TheUnlocked added a commit to TheUnlocked/node that referenced this issue Oct 14, 2019
@TheUnlocked
Resolves nodejs#29959
c3eea4c 
Corrects "--source-map-support" to "--enable-source-maps"
@TheUnlocked TheUnlocked mentioned this issue Oct 14, 2019
Closed
@AviVahl
Copy link
Author

AviVahl commented Oct 14, 2019

might also want to fix the release notes @ https://github.com/nodejs/node/releases/tag/v12.12.0

@Trott
Copy link
Member

Trott commented Oct 14, 2019

might also want to fix the release notes @ https://github.com/nodejs/node/releases/tag/v12.12.0

@BridgeAR @nodejs/releasers As far as you know, would there be any problem created by editing the release notes at that location?

@Trott Trott mentioned this issue Oct 14, 2019
Merged
@targos
Copy link
Member

targos commented Oct 14, 2019

would there be any problem created by editing the release notes at that location?

No. I've done that before.

@BridgeAR
Copy link
Member

I just updated the release notes. Thanks a lot for the quick report @AviVahl.

targos pushed a commit that referenced this issue Oct 14, 2019
@TheUnlocked @targos
doc: fix --enable-source-maps flag in v12.12.0 changelog
1dde617 
Corrects "--source-map-support" to "--enable-source-maps".

Fixes: #29959
PR-URL: #29960
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@addaleax addaleax added doc Issues and PRs related to the documentations. source maps Issues and PRs related to source map support. labels Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. source maps Issues and PRs related to source map support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: fix --enable-source-maps flag in v12.12.0 changelog TheUnlocked/node
6 participants
@bcoe @Trott @addaleax @targos @BridgeAR @AviVahl