Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong option name in en/blog/release/v12.12.0.md #2676

Merged
merged 1 commit into from
Oct 14, 2019

Conversation

mysticatea
Copy link
Contributor

I found the option name in the blog post is wrong.

$ node --source-map-support
C:\Program Files (x86)\Nodist/v-x64/12.12.0/node.exe: bad option: --source-map-support

$ node --enable-source-maps
Welcome to Node.js v12.12.0.
Type ".help" for more information.
>

Copy link
Member

@nschonni nschonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks like the naming changed between the initial PR and description and the final commit

@Trott
Copy link
Member

Trott commented Oct 14, 2019

Refs: nodejs/node#29959
Refs: nodejs/node#29960

I suspect they'll both be 👍 on it, but /ping @bcoe @BridgeAR anyway

@Trott
Copy link
Member

Trott commented Oct 14, 2019

Actually, this is kind of important (as people are reading this blog post now but not so much in a week) so I'm going to land this right away. We can always change it again if need be.

@Trott Trott merged commit 1563e3a into nodejs:master Oct 14, 2019
@BridgeAR
Copy link
Member

Thank a lot for the fix.

@mysticatea mysticatea deleted the patch-1 branch October 14, 2019 09:29
@bcoe
Copy link

bcoe commented Oct 14, 2019

@Trott thanks for catching this and fixing it.

@bcoe
Copy link

bcoe commented Oct 14, 2019

likewise @mysticatea, thank you both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants