Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JOBS=1 make does not work at macOS #38578

Open
pd4d10 opened this issue May 7, 2021 · 0 comments
Open

JOBS=1 make does not work at macOS #38578

pd4d10 opened this issue May 7, 2021 · 0 comments
Labels
build Issues and PRs related to build files or the CI.

Comments

@pd4d10
Copy link
Contributor

pd4d10 commented May 7, 2021 •
edited
Loading

JOBS=1 make (with ninja) does not work. It still use all cores instead of the specified 1 core.

Because the line which starts with tab and the one without tab mean different in Makefile. For more information see Recipe-Syntax

It seems to be introduced in this PR: #28881
pd4d10 added a commit to pd4d10/node that referenced this issue May 7, 2021
@pd4d10
build: fix Makefile conditions
7a26c3d 
Fixes: nodejs#38578
@pd4d10 pd4d10 mentioned this issue May 7, 2021
Closed
@Ayase-252 Ayase-252 added the build Issues and PRs related to build files or the CI. label May 7, 2021
@pd4d10 pd4d10 changed the title Some conditions in Makefile do not work JOBS=1 make does not work at macOS May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: fix Makefile conditions pd4d10/node
2 participants
@Ayase-252 @pd4d10