build: fix Makefile conditions

[pd4d10]

Fixes: #38578

[lpinca]

It seems to work fine as is:

$ make --version
GNU Make 4.2.1
Built for x86_64-pc-linux-gnu
Copyright (C) 1988-2016 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

$ cat Makefile
ifdef JOBS
        PARALLEL_ARGS = -j $(JOBS)
else
        PARALLEL_ARGS = -J
endif

.PHONY: all
all:
        $(info PARALLEL_ARGS is "$(PARALLEL_ARGS)") @true

$ JOBS=1 make
PARALLEL_ARGS is "-j 1"

[pd4d10]

Oh, that's weird. I tested the built-in make and the GNU make (by brew install make) at macOS, and both do not work.

> make --version
GNU Make 3.81
Copyright (C) 2006  Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.

This program built for i386-apple-darwin11.3.0

> gmake --version
GNU Make 4.3
Built for x86_64-apple-darwin20.1.0
Copyright (C) 1988-2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

[pd4d10]

$ cat Makefile
ifdef JOBS
        PARALLEL_ARGS = -j $(JOBS)
else
        PARALLEL_ARGS = -J
endif

.PHONY: all
all:
        $(info PARALLEL_ARGS is "$(PARALLEL_ARGS)") @true

This one works fine for me too... but the Node.js one not.

Thanks for the information! @lpinca I'll try to look into it further

[github-actions]

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

[github-actions]

Closing this because it has stalled. Feel free to reopen if this issue/PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.