Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test-cluster-shared-leak on Win10 #4887

Closed
Trott opened this issue Jan 26, 2016 · 2 comments
Closed

Investigate flaky test-cluster-shared-leak on Win10 #4887

Trott opened this issue Jan 26, 2016 · 2 comments
Labels
cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.

Comments

@Trott
Copy link
Member

Trott commented Jan 26, 2016

Windows 10 stress test showing flakiness: https://ci.nodejs.org/job/node-stress-single-test/371/nodes=win10/console
@Trott Trott added cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests. labels Jan 26, 2016
@Trott Trott mentioned this issue Jan 26, 2016
Closed
@Trott
Copy link
Member Author

Trott commented Jan 26, 2016

Also, failure in CI: https://ci.nodejs.org/job/node-test-binary-windows/757/

@mscdex mscdex added the windows Issues and PRs related to the Windows platform. label Jan 27, 2016
@Trott
Copy link
Member Author

Trott commented Jan 28, 2016

And...another one: https://ci.nodejs.org/job/node-test-binary-windows/798/RUN_SUBSET=0,VS_VERSION=vs2015,label=win10/console

@Trott Trott mentioned this issue Jan 28, 2016
Closed
Trott added a commit to Trott/io.js that referenced this issue Jan 28, 2016
@Trott
test: fix flaky cluster test on Windows 10
3b560ad 
test-cluster-shared-leak was flaky on Windows 10. Remove unnecessary
.send() calls and replace with .disconnect() to avoid spurious EPIPE.

Fixes: nodejs#4887
PR-URL: nodejs#4934
@Trott Trott closed this as completed in 25f8a0d Jan 31, 2016
rvagg pushed a commit that referenced this issue Feb 8, 2016
@Trott @rvagg
test: fix flaky cluster test on Windows 10
90219c3 
test-cluster-shared-leak was flaky on Windows 10. Remove unnecessary
.send() calls and replace with .disconnect() to avoid spurious EPIPE.

Fixes: #4887
PR-URL: #4934
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Feb 17, 2016
@Trott
test: fix flaky cluster test on Windows 10
8a6dd5b 
test-cluster-shared-leak was flaky on Windows 10. Remove unnecessary
.send() calls and replace with .disconnect() to avoid spurious EPIPE.

Fixes: #4887
PR-URL: #4934
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Feb 18, 2016
@Trott
test: fix flaky cluster test on Windows 10
fb14bac 
test-cluster-shared-leak was flaky on Windows 10. Remove unnecessary
.send() calls and replace with .disconnect() to avoid spurious EPIPE.

Fixes: #4887
PR-URL: #4934
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Mar 2, 2016
@Trott
test: fix flaky cluster test on Windows 10
efbb654 
test-cluster-shared-leak was flaky on Windows 10. Remove unnecessary
.send() calls and replace with .disconnect() to avoid spurious EPIPE.

Fixes: #4887
PR-URL: #4934
Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this issue Apr 2, 2016
@Trott
test: fix flaky cluster test on Windows 10
c1fd7a1 
test-cluster-shared-leak was flaky on Windows 10. Remove unnecessary
.send() calls and replace with .disconnect() to avoid spurious EPIPE.

Fixes: nodejs#4887
PR-URL: nodejs#4934
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mscdex @Trott