Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky cluster test on Windows 10 #4934

Closed
wants to merge 1 commit into from
Closed

test: fix flaky cluster test on Windows 10 #4934

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 28, 2016

test: fix flaky cluster test on Windows 10

test-cluster-shared-leak was flaky on Windows 10. Remove unnecessary
.send() calls and replace with .disconnect() to avoid spurious EPIPE.

@Trott Trott added cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests. labels Jan 28, 2016
@Trott
Copy link
Member Author

Trott commented Jan 28, 2016

Fixes #4887

@Trott
test: fix flaky cluster test on Windows 10
3b560ad 
test-cluster-shared-leak was flaky on Windows 10. Remove unnecessary
.send() calls and replace with .disconnect() to avoid spurious EPIPE.

Fixes: nodejs#4887
PR-URL: nodejs#4934
@Trott Trott changed the title test: fix flaky test again test: fix flaky cluster test on Windows 10 Jan 28, 2016
@Trott
Copy link
Member Author

Trott commented Jan 28, 2016

Here are stress tests with this fix:

Job Number Host Branch Failures
382 test-azure_msft-win10-x64-5 fix-flaky-again 0
384 test-azure_msft-win10-x64-1 fix-flaky-again 0
385 test-azure_msft-win10-x64-2 fix-flaky-again 0
386 test-azure_msft-win10-x64-4 fix-flaky-again 0

Here are stress tests without this fix:

Job Number Host Branch Failures
378 test-azure_msft-win10-x64-4 master 11
383 test-azure_msft-win10-x64-5 master 0
387 test-azure_msft-win10-x64-5 master 1
388 test-azure_msft-win10-x64-3 master 14
389 test-azure_msft-win10-x64-2 master 13
390 test-azure_msft-win10-x64-1 master 4
394 test-azure_msft-win10-x64-4 master 7

@jbergstroem
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-commit/1962/

@Trott
Copy link
Member Author

Trott commented Jan 28, 2016

Confirmed that the test still throws an AssertionError in Node 4.2.1 (which has the bug that this test is written to detect) and runs without throwing any errors in Node 4.2.2 (which has the fix for the bug).

$ nvm use 4.2.1
Now using node v4.2.1 (npm v2.14.7)
$ node test/parallel/test-cluster-shared-leak.js 

assert.js:89
  throw new assert.AssertionError({
  ^
AssertionError: Resource leak detected.
    at removeWorker (cluster.js:328:9)
    at ChildProcess.<anonymous> (cluster.js:348:34)
    at ChildProcess.g (events.js:260:16)
    at emitTwo (events.js:87:13)
    at ChildProcess.emit (events.js:172:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
$ nvm use 4.2.2
Now using node v4.2.2 (npm v2.14.7)
$ node test/parallel/test-cluster-shared-leak.js 
$

@Trott
Copy link
Member Author

Trott commented Jan 28, 2016

CI is green! \o/

@jasnell
Copy link
Member

jasnell commented Jan 29, 2016

lts watch tag applied. LGTM

Trott added a commit to Trott/io.js that referenced this pull request Jan 31, 2016
@Trott
test: fix flaky cluster test on Windows 10
25f8a0d 
test-cluster-shared-leak was flaky on Windows 10. Remove unnecessary
.send() calls and replace with .disconnect() to avoid spurious EPIPE.

Fixes: nodejs#4887
PR-URL: nodejs#4934
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member Author

Trott commented Jan 31, 2016

Landed in 25f8a0d

@Trott Trott closed this Jan 31, 2016
rvagg pushed a commit that referenced this pull request Feb 8, 2016
@Trott @rvagg
test: fix flaky cluster test on Windows 10
90219c3 
test-cluster-shared-leak was flaky on Windows 10. Remove unnecessary
.send() calls and replace with .disconnect() to avoid spurious EPIPE.

Fixes: #4887
PR-URL: #4934
Reviewed-By: James M Snell <jasnell@gmail.com>
@rvagg rvagg mentioned this pull request Feb 8, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Feb 17, 2016
@Trott
test: fix flaky cluster test on Windows 10
8a6dd5b 
test-cluster-shared-leak was flaky on Windows 10. Remove unnecessary
.send() calls and replace with .disconnect() to avoid spurious EPIPE.

Fixes: #4887
PR-URL: #4934
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
@Trott
test: fix flaky cluster test on Windows 10
fb14bac 
test-cluster-shared-leak was flaky on Windows 10. Remove unnecessary
.send() calls and replace with .disconnect() to avoid spurious EPIPE.

Fixes: #4887
PR-URL: #4934
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 18, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
@Trott
test: fix flaky cluster test on Windows 10
efbb654 
test-cluster-shared-leak was flaky on Windows 10. Remove unnecessary
.send() calls and replace with .disconnect() to avoid spurious EPIPE.

Fixes: #4887
PR-URL: #4934
Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@Trott
test: fix flaky cluster test on Windows 10
c1fd7a1 
test-cluster-shared-leak was flaky on Windows 10. Remove unnecessary
.send() calls and replace with .disconnect() to avoid spurious EPIPE.

Fixes: nodejs#4887
PR-URL: nodejs#4934
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott Trott deleted the fix-flaky-again branch January 13, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @jbergstroem @jasnell @MylesBorins