Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules: node:module API > Customization Hooks > Examples > Import from HTTPS #55091

Closed
77it opened this issue Sep 23, 2024 · 6 comments · Fixed by #55111
Closed

Modules: node:module API > Customization Hooks > Examples > Import from HTTPS #55091

77it opened this issue Sep 23, 2024 · 6 comments · Fixed by #55111
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. module Issues and PRs related to the module subsystem.

Comments

@77it
Copy link

77it commented Sep 23, 2024

Affected URL(s)

https://nodejs.org/dist/latest/docs/api/module.html#import-from-https

Description of the problem

in the page is present a text pointing to an header no more live

In current Node.js, specifiers starting with https:// are experimental (see [HTTPS and HTTP imports][]).

in the previous documentation version the link pointed to https://nodejs.org/docs/latest-v21.x/api/esm.html#https-and-http-imports that is now removed

@77it 77it added the doc Issues and PRs related to the documentations. label Sep 23, 2024
@77it
Copy link
Author

77it commented Sep 23, 2024

Also, after the removal of --experimental-network-imports with #53822, I wanted to ask if importing modules from HTTPS with hooks is a feature that can be relied on in the future, or can be subject to removal as happened with --experimental-network-imports.

@RedYetiDev
Copy link
Member

RedYetiDev commented Sep 23, 2024

Looks like an oversight, feel free to submit a PR removing it if you'd like (You'll get a shiny contributor badge 👀 ). The entire feature has been removed, it just looks like the docs werent updated.

@RedYetiDev RedYetiDev added loaders Issues and PRs related to ES module loaders module Issues and PRs related to the module subsystem. good first issue Issues that are suitable for first-time contributors. and removed loaders Issues and PRs related to ES module loaders labels Sep 23, 2024
@geeksilva97
Copy link
Contributor

geeksilva97 commented Sep 24, 2024

@77it let me know if I can work on this PR.

@geeksilva97
Copy link
Contributor

@RedYetiDev should the whole section Import from HTTPS be removed?

@RedYetiDev
Copy link
Member

No, just that line. The section is showing an example of how to setup an HTTP(S) import.

@77it
Copy link
Author

77it commented Sep 25, 2024

@77it let me know if I can work on this PR.

Sure, fine for me

The whole section must be preserved, only the obsolete line have to be removed

nodejs-github-bot pushed a commit that referenced this issue Sep 28, 2024
PR-URL: #55111
Fixes: #55091
Refs: #53822
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this issue Oct 4, 2024
PR-URL: #55111
Fixes: #55091
Refs: #53822
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this issue Oct 4, 2024
PR-URL: #55111
Fixes: #55091
Refs: #53822
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
louwers pushed a commit to louwers/node that referenced this issue Nov 2, 2024
PR-URL: nodejs#55111
Fixes: nodejs#55091
Refs: nodejs#53822
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
tpoisseau pushed a commit to tpoisseau/node that referenced this issue Nov 21, 2024
PR-URL: nodejs#55111
Fixes: nodejs#55091
Refs: nodejs#53822
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. module Issues and PRs related to the module subsystem.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants