Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove outdated https import reference #55111

Merged
merged 1 commit into from
Sep 28, 2024
Merged

doc: remove outdated https import reference #55111

merged 1 commit into from
Sep 28, 2024

Conversation

geeksilva97
Copy link
Contributor

@geeksilva97 geeksilva97 commented Sep 25, 2024 •
edited by aduh95
Loading

Refs: #53822
Fixes: #55091

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Sep 25, 2024
@RedYetiDev
Copy link
Member

RedYetiDev commented Sep 25, 2024 •
edited
Loading

Can you amend your commit message to start with the subsystem you are changing, in this case doc?

A valid commit would look like:

doc: remove outdated https import reference

@geeksilva97
Copy link
Contributor Author

Can you amend your commit message to start with the subsystem you are changing, in this case doc?

A valid commit would look like:

doc: remove outdated https import reference

Done

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 25, 2024
@geeksilva97 geeksilva97 changed the title Remove old references from doc doc: remove outdated https import reference Sep 27, 2024
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 28, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 28, 2024
@nodejs-github-bot nodejs-github-bot merged commit 6d1cd50 into nodejs:main Sep 28, 2024
20 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 6d1cd50

targos pushed a commit that referenced this pull request Oct 4, 2024
@geeksilva97 @targos
doc: remove outdated https import reference
1f7566d 
PR-URL: #55111
Fixes: #55091
Refs: #53822
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Oct 4, 2024
@geeksilva97 @targos
doc: remove outdated https import reference
bb34990 
PR-URL: #55111
Fixes: #55091
Refs: #53822
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@geeksilva97 @louwers
doc: remove outdated https import reference
b1a542e 
PR-URL: nodejs#55111
Fixes: nodejs#55091
Refs: nodejs#53822
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@marco-ippolito marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Nov 16, 2024
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@geeksilva97 @tpoisseau
doc: remove outdated https import reference
a4a7c32 
PR-URL: nodejs#55111
Fixes: nodejs#55091
Refs: nodejs#53822
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlowChemi atlowChemi atlowChemi approved these changes

@aduh95 aduh95 aduh95 approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. module Issues and PRs related to the module subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modules: node:module API > Customization Hooks > Examples > Import from HTTPS
8 participants
@geeksilva97 @nodejs-github-bot @RedYetiDev @lpinca @UlisesGascon @aduh95 @atlowChemi @marco-ippolito