Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backtrace_posix.cc fails to compile on AIX #7539

Closed
mhdawson opened this issue Jul 5, 2016 · 3 comments
Closed

backtrace_posix.cc fails to compile on AIX #7539

mhdawson opened this issue Jul 5, 2016 · 3 comments
Assignees
Labels
build Issues and PRs related to build files or the CI.

Comments

@mhdawson
Copy link
Member

mhdawson commented Jul 5, 2016

  • Version: master
  • Platform: AIX
  • Subsystem: core

Compile failure on AIX: https://ci.nodejs.org/job/node-test-commit-aix/nodes=aix61-ppc64/242/console

  g++ '-DNODE_ARCH="ppc64"' '-DNODE_PLATFORM="aix"' '-DNODE_WANT_INTERNALS=1' '-DV8_DEPRECATION_WARNINGS=1' '-DNODE_USE_V8_PLATFORM=1' '-DNODE_HAVE_I18N_SUPPORT=1' '-DNODE_HAVE_SMALL_ICU=1' '-DHAVE_INSPECTOR=1' '-DV8_INSPECTOR_USE_STL=1' '-DHAVE_OPENSSL=1' '-D__POSIX__' '-D_LINUX_SOURCE_COMPAT' '-DUCONFIG_NO_TRANSLITERATION=1' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=0' '-DUCONFIG_NO_BREAK_ITERATION=0' '-DUCONFIG_NO_CONVERSION=1' '-DHTTP_PARSER_STRICT=0' '-D_LARGEFILE_SOURCE' '-D_FILE_OFFSET_BITS=64' -I../src -I../tools/msvs/genfiles -I../deps/uv/src/ares -I/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/out/Release/obj/gen -I../deps/v8_inspector -I../deps/v8_inspector/deps/wtf -I/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/out/Release/obj/gen/blink -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common -I../deps/openssl/openssl/include -I../deps/zlib -I../deps/http_parser -I../deps/cares/include -I../deps/uv/include  -pthread -Wall -Wextra -Wno-unused-parameter -maix64 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++0x -MMD -MF /home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/out/Release/.deps//home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/out/Release/obj.target/node_base/src/backtrace_posix.o.d.raw   -c -o /home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/out/Release/obj.target/node_base/src/backtrace_posix.o ../src/backtrace_posix.cc
../src/backtrace_posix.cc:16:22: fatal error: execinfo.h: No such file or directory
 #include 
                      ^

Related to: #6734

Have discussed fix with @gireeshpunathil , will test out PR soon

@Trott
Copy link
Member

Trott commented Jul 5, 2016

FWIW, it appears that the file has 0% test coverage: https://node-core-coverage.addaleax.net/coverage-475dc439e21dd257/cxxcoverage._home_node-core-coverage_node-core-coverage_workdir_node_src_backtrace_posix.cc.html

(Caveat: That test coverage data is for Linux only, possibly other caveats I'm not aware of.)

So, uh, if the fix for this also gets at least some test coverage happening there, that would be a nice benefit.

@bnoordhuis
Copy link
Member

There is test coverage in test/abort but that doesn't run on the CI.

@mhdawson
Copy link
Member Author

mhdawson commented Jul 5, 2016

PR to resolve compile failure: #7544

@mscdex mscdex added the build Issues and PRs related to build files or the CI. label Jul 5, 2016
Fishrock123 pushed a commit that referenced this issue Jul 6, 2016
Fix compile failure in backtrace_posix.c on AIX

Fixes: #7539
PR-URL: #7544
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

No branches or pull requests

4 participants