Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Fix compile failure in backtrace_posix.cc #7544

Closed
wants to merge 1 commit into from
Closed

build: Fix compile failure in backtrace_posix.cc #7544

wants to merge 1 commit into from

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Jul 5, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

core

Description of change

Fix compile failure in backtrace_posix.c on AIX introduced by #6734

@mhdawson
build: Fix compile failure in backtrace_posix.cc
ee3ed0f 
Fix compile failure in backtrace_posix.c on AIX
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jul 5, 2016
@mhdawson mhdawson mentioned this pull request Jul 5, 2016
Closed
@mhdawson
Copy link
Member Author

mhdawson commented Jul 5, 2016

@bnoordhuis

@mhdawson
Copy link
Member Author

mhdawson commented Jul 5, 2016

CI run https://ci.nodejs.org/job/node-test-pull-request/3181/

@cjihrig
Copy link
Contributor

cjihrig commented Jul 5, 2016

LGTM

@mhdawson
Copy link
Member Author

mhdawson commented Jul 5, 2016

Going to land this once the CI run completes since it fixes a build break and the change is small and have one LGTM altready.

@bnoordhuis
Copy link
Member

LGTM

1 similar comment
@mscdex
Copy link
Contributor

mscdex commented Jul 5, 2016

LGTM

@mhdawson
Copy link
Member Author

mhdawson commented Jul 5, 2016

CI is good landing

@mhdawson
Copy link
Member Author

mhdawson commented Jul 5, 2016

Landed as 95a3c8f

mhdawson added a commit that referenced this pull request Jul 5, 2016
@mhdawson
build: Fix compile failure in backtrace_posix.cc
95a3c8f 
Fix compile failure in backtrace_posix.c on AIX

Fixes: #7539
PR-URL: #7544
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
@mhdawson mhdawson closed this Jul 5, 2016
Fishrock123 pushed a commit that referenced this pull request Jul 6, 2016
@mhdawson @Fishrock123
build: Fix compile failure in backtrace_posix.cc
5e4113e 
Fix compile failure in backtrace_posix.c on AIX

Fixes: #7539
PR-URL: #7544
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
@Fishrock123 Fishrock123 mentioned this pull request Jul 6, 2016
Merged
@MylesBorins MylesBorins mentioned this pull request Jul 11, 2016
Closed
@MylesBorins
Copy link
Contributor

@mhdawson lts?

@MylesBorins MylesBorins mentioned this pull request Jul 14, 2016
Merged
@MylesBorins
Copy link
Contributor

needs to be backported if #6734 is backported

@mhdawson mhdawson deleted the aixstack branch March 15, 2017 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mhdawson @cjihrig @bnoordhuis @mscdex @MylesBorins @nodejs-github-bot