Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate flaky sequential/test-child-process-pass-fd on SmartoS #8209

Closed
Trott opened this issue Aug 21, 2016 · 0 comments
Closed

investigate flaky sequential/test-child-process-pass-fd on SmartoS #8209

Trott opened this issue Aug 21, 2016 · 0 comments
Labels
child_process Issues and PRs related to the child_process subsystem. smartos Issues and PRs related to the SmartOS platform. test Issues and PRs related to the tests.

Comments

@Trott
Copy link
Member

Trott commented Aug 21, 2016

Looks like it's the result of side effects from other test runs. Could possibly be solved by removing the reliance on common.PORT. /cc @nodejs/testing

https://ci.nodejs.org/job/node-test-commit-smartos/3836/nodes=smartos14-32/console:

not ok 1189 sequential/test-child-process-pass-fd
# events.js:160
#       throw er; // Unhandled 'error' event
#       ^
# 
# Error: listen EADDRINUSE 127.0.0.1:12408
#     at Object.exports._errnoException (util.js:1026:11)
#     at exports._exceptionWithHostPort (util.js:1049:20)
#     at Server._listen2 (net.js:1253:14)
#     at listen (net.js:1289:10)
#     at net.js:1399:9
#     at _combinedTickCallback (internal/process/next_tick.js:77:11)
#     at process._tickCallback (internal/process/next_tick.js:98:9)
#     at Module.runMain (module.js:592:11)
#     at run (bootstrap_node.js:382:7)
#     at startup (bootstrap_node.js:137:9)
# events.js:160
#       throw er; // Unhandled 'error' event
#       ^
# 
# Error: listen EADDRINUSE 127.0.0.1:12409
#     at Object.exports._errnoException (util.js:1026:11)
#     at exports._exceptionWithHostPort (util.js:1049:20)
#     at Server._listen2 (net.js:1253:14)
#     at listen (net.js:1289:10)
#     at net.js:1399:9
#     at _combinedTickCallback (internal/process/next_tick.js:77:11)
#     at process._tickCallback (internal/process/next_tick.js:98:9)
#     at Module.runMain (module.js:592:11)
#     at run (bootstrap_node.js:382:7)
#     at startup (bootstrap_node.js:137:9)
# events.js:160
#       throw er; // Unhandled 'error' event
#       ^
# 
# Error: listen EADDRINUSE 127.0.0.1:12410
#     at Object.exports._errnoException (util.js:1026:11)
#     at exports._exceptionWithHostPort (util.js:1049:20)
#     at Server._listen2 (net.js:1253:14)
#     at listen (net.js:1289:10)
#     at net.js:1399:9
#     at _combinedTickCallback (internal/process/next_tick.js:77:11)
#     at process._tickCallback (internal/process/next_tick.js:98:9)
#     at Module.runMain (module.js:592:11)
#     at run (bootstrap_node.js:382:7)
#     at startup (bootstrap_node.js:137:9)
# events.js:160
#       throw er; // Unhandled 'error' event
#       ^
# 
# Error: listen EADDRINUSE 127.0.0.1:12411
#     at Object.exports._errnoException (util.js:1026:11)
#     at exports._exceptionWithHostPort (util.js:1049:20)
#     at Server._listen2 (net.js:1253:14)
#     at listen (net.js:1289:10)
#     at net.js:1399:9
#     at _combinedTickCallback (internal/process/next_tick.js:77:11)
#     at process._tickCallback (internal/process/next_tick.js:98:9)
#     at Module.runMain (module.js:592:11)
#     at run (bootstrap_node.js:382:7)
#     at startup (bootstrap_node.js:137:9)
# events.js:160
#       throw er; // Unhandled 'error' event
#       ^
# 
# Error: listen EADDRINUSE 127.0.0.1:12412
#     at Object.exports._errnoException (util.js:1026:11)
#     at exports._exceptionWithHostPort (util.js:1049:20)
#     at Server._listen2 (net.js:1253:14)
#     at listen (net.js:1289:10)
#     at net.js:1399:9
#     at _combinedTickCallback (internal/process/next_tick.js:77:11)
#     at process._tickCallback (internal/process/next_tick.js:98:9)
#     at Module.runMain (module.js:592:11)
#     at run (bootstrap_node.js:382:7)
#     at startup (bootstrap_node.js:137:9)
# events.js:160
#       throw er; // Unhandled 'error' event
#       ^
# 
# Error: listen EADDRINUSE 127.0.0.1:12413
#     at Object.exports._errnoException (util.js:1026:11)
#     at exports._exceptionWithHostPort (util.js:1049:20)
#     at Server._listen2 (net.js:1253:14)
#     at listen (net.js:1289:10)
#     at net.js:1399:9
#     at _combinedTickCallback (internal/process/next_tick.js:77:11)
#     at process._tickCallback (internal/process/next_tick.js:98:9)
#     at Module.runMain (module.js:592:11)
#     at run (bootstrap_node.js:382:7)
#     at startup (bootstrap_node.js:137:9)
# events.js:160
#       throw er; // Unhandled 'error' event
#       ^
# 
# Error: listen EADDRINUSE 127.0.0.1:12414
#     at Object.exports._errnoException (util.js:1026:11)
#     at exports._exceptionWithHostPort (util.js:1049:20)
#     at Server._listen2 (net.js:1253:14)
#     at listen (net.js:1289:10)
#     at net.js:1399:9
#     at _combinedTickCallback (internal/process/next_tick.js:77:11)
#     at process._tickCallback (internal/process/next_tick.js:98:9)
#     at Module.runMain (module.js:592:11)
#     at run (bootstrap_node.js:382:7)
#     at startup (bootstrap_node.js:137:9)
# Mismatched <anonymous> function calls. Expected 1, actual 0.
#     at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-32/test/sequential/test-child-process-pass-fd.js:18:35)
#     at Module._compile (module.js:556:32)
#     at Object.Module._extensions..js (module.js:565:10)
#     at Module.load (module.js:473:32)
#     at tryModuleLoad (module.js:432:12)
#     at Function.Module._load (module.js:424:3)
#     at Module.runMain (module.js:590:10)
#     at run (bootstrap_node.js:382:7)
#     at startup (bootstrap_node.js:137:9)
# Mismatched <anonymous> function calls. Expected 1, actual 0.
#     at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-32/test/sequential/test-child-process-pass-fd.js:18:35)
#     at Module._compile (module.js:556:32)
#     at Object.Module._extensions..js (module.js:565:10)
#     at Module.load (module.js:473:32)
#     at tryModuleLoad (module.js:432:12)
#     at Function.Module._load (module.js:424:3)
#     at Module.runMain (module.js:590:10)
#     at run (bootstrap_node.js:382:7)
#     at startup (bootstrap_node.js:137:9)
# Mismatched <anonymous> function calls. Expected 1, actual 0.
#     at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-32/test/sequential/test-child-process-pass-fd.js:18:35)
#     at Module._compile (module.js:556:32)
#     at Object.Module._extensions..js (module.js:565:10)
#     at Module.load (module.js:473:32)
#     at tryModuleLoad (module.js:432:12)
#     at Function.Module._load (module.js:424:3)
#     at Module.runMain (module.js:590:10)
#     at run (bootstrap_node.js:382:7)
#     at startup (bootstrap_node.js:137:9)
# Mismatched <anonymous> function calls. Expected 1, actual 0.
#     at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-32/test/sequential/test-child-process-pass-fd.js:18:35)
#     at Module._compile (module.js:556:32)
#     at Object.Module._extensions..js (module.js:565:10)
#     at Module.load (module.js:473:32)
#     at tryModuleLoad (module.js:432:12)
#     at Function.Module._load (module.js:424:3)
#     at Module.runMain (module.js:590:10)
#     at run (bootstrap_node.js:382:7)
#     at startup (bootstrap_node.js:137:9)
# Mismatched <anonymous> function calls. Expected 1, actual 0.
#     at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-32/test/sequential/test-child-process-pass-fd.js:18:35)
#     at Module._compile (module.js:556:32)
#     at Object.Module._extensions..js (module.js:565:10)
#     at Module.load (module.js:473:32)
#     at tryModuleLoad (module.js:432:12)
#     at Function.Module._load (module.js:424:3)
#     at Module.runMain (module.js:590:10)
#     at run (bootstrap_node.js:382:7)
#     at startup (bootstrap_node.js:137:9)
# Mismatched <anonymous> function calls. Expected 1, actual 0.
#     at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-32/test/sequential/test-child-process-pass-fd.js:18:35)
#     at Module._compile (module.js:556:32)
#     at Object.Module._extensions..js (module.js:565:10)
#     at Module.load (module.js:473:32)
#     at tryModuleLoad (module.js:432:12)
#     at Function.Module._load (module.js:424:3)
#     at Module.runMain (module.js:590:10)
#     at run (bootstrap_node.js:382:7)
#     at startup (bootstrap_node.js:137:9)
# Mismatched <anonymous> function calls. Expected 1, actual 0.
#     at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-32/test/sequential/test-child-process-pass-fd.js:18:35)
#     at Module._compile (module.js:556:32)
#     at Object.Module._extensions..js (module.js:565:10)
#     at Module.load (module.js:473:32)
#     at tryModuleLoad (module.js:432:12)
#     at Function.Module._load (module.js:424:3)
#     at Module.runMain (module.js:590:10)
#     at run (bootstrap_node.js:382:7)
#     at startup (bootstrap_node.js:137:9)
  ---
  duration_ms: 10.307
@Trott Trott added child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests. smartos Issues and PRs related to the SmartOS platform. labels Aug 21, 2016
santigimeno added a commit to santigimeno/node that referenced this issue Aug 21, 2016
@santigimeno
test: fix flaky test-child-process-pass-fd
7cdf240 
Listen on random ports instead of using `common.PORT`.

Fixes: nodejs#8209
This was referenced Aug 21, 2016
Closed
Closed
@Trott Trott closed this as completed in 64cbe7a Aug 22, 2016
evanlucas pushed a commit that referenced this issue Aug 24, 2016
@santigimeno @evanlucas
test: fix flaky test-child-process-pass-fd
bb6d6a6 
Listen on random ports instead of using `common.PORT`.

Fixes: #8209
PR-URL: #8212
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. smartos Issues and PRs related to the SmartOS platform. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix flaky test-child-process-pass-fd santigimeno/node
1 participant
@Trott