Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: failed on sequential/test-child-process-pass-fd #8219

Closed
yorkie opened this issue Aug 22, 2016 · 3 comments
Closed

test: failed on sequential/test-child-process-pass-fd #8219

yorkie opened this issue Aug 22, 2016 · 3 comments
Labels
child_process Issues and PRs related to the child_process subsystem. duplicate Issues and PRs that are duplicates of other issues or PRs. test Issues and PRs related to the tests.

Comments

@yorkie
Copy link
Contributor

yorkie commented Aug 22, 2016

  • Version: master
  • Platform: smartos
  • Subsystem: test/ci, child_process

The CI in #8198 failed on sequential/test-child-process-pass-fd, which is added at db6253f.

By the way, that commit is to fix an issue on OSX, my question is why would we test it on smartos? is it exactly right behavior?

to mention the commit author @santigimeno

@yorkie yorkie added the test Issues and PRs related to the tests. label Aug 22, 2016
@mscdex mscdex added the child_process Issues and PRs related to the child_process subsystem. label Aug 22, 2016
@santigimeno
Copy link
Member

There's already an issue: #8209 and a PR: #8212 that tries to fix the issue.

By the way, that commit is to fix an issue on OSX, my question is why would we test it on smartos? is it exactly right behavior?

That commit fixed an issue on OS X by modifying when the passed descriptors are closed for every platform, so I think it makes sense to test it everywhere.

@addaleax addaleax added the duplicate Issues and PRs that are duplicates of other issues or PRs. label Aug 22, 2016
@addaleax
Copy link
Member

I guess this can be closed as a duplicate then?

@yorkie
Copy link
Contributor Author

yorkie commented Aug 22, 2016

Thanks @santigimeno @addaleax :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem. duplicate Issues and PRs that are duplicates of other issues or PRs. test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

4 participants