async_wrap: add a missing case to test-async-wrap-throw-no-init #8198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM if CI is green. |
|
The CI seems to fail on the following errors:
|
|
LGTM |
|
Re-running a new ci: https://ci.nodejs.org/job/node-test-pull-request/3815/ |
PR-URL: nodejs#8198 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
yorkie
force-pushed
the
test-async-wrap-throw-no-init
branch
from
c49a070 to
10b3f13
Compare
|
Landed at 10b3f13, thanks for reviews :) |
Closed
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Sep 8, 2016
PR-URL: nodejs#8198 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Sep 9, 2016
PR-URL: #8198 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 30, 2016
PR-URL: #8198 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
|
I've landed this on v4.x-staging. @trevnorris @yorkie let me know if it should not have landed |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 10, 2016
PR-URL: #8198 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
PR-URL: #8198 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
PR-URL: #8198 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
async_wrap, test
Description of change
This covers this line in "src/async-wrap.cc". /R= @trevnorris