Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor http pipelined socket test #10189

Closed
wants to merge 1 commit into from
Closed

test: refactor http pipelined socket test #10189

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 9, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test http

Description of change

In test-http-incoming-pipelined-socket-destory:

  • setTimeout() with no duration -> setImmediate()
  • eliminate unneeded exit listener
  • use common.mustCall()
  • var -> const/let

@Trott
tets: refactor http pipelined socket test
582abb0 
In test-http-incoming-pipelined-socket-destory:

* setTimeout() with no duration -> setImmediate()
* eliminate unneeded exit listener
* use common.mustCall()
* var -> const/let
@Trott Trott added http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests. labels Dec 9, 2016
@Trott
Copy link
Member Author

Trott commented Dec 9, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5337/

santigimeno
santigimeno approved these changes Dec 9, 2016
View reviewed changes
Copy link
Member

@santigimeno santigimeno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Nit: s/tets/test in the commit message

@Trott Trott changed the title tets: refactor http pipelined socket test test: refactor http pipelined socket test Dec 12, 2016
Trott added a commit to Trott/io.js that referenced this pull request Dec 12, 2016
@Trott
test: refactor http pipelined socket test
7346e55 
In test-http-incoming-pipelined-socket-destory:

* setTimeout() with no duration -> setImmediate()
* eliminate unneeded exit listener
* use common.mustCall()
* var -> const/let

PR-URL: nodejs#10189
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@Trott
Copy link
Member Author

Trott commented Dec 12, 2016

Landed in 7346e55.

@Trott Trott closed this Dec 12, 2016
Fishrock123 pushed a commit that referenced this pull request Dec 13, 2016
@Trott @Fishrock123
test: refactor http pipelined socket test
3749dc6 
In test-http-incoming-pipelined-socket-destory:

* setTimeout() with no duration -> setImmediate()
* eliminate unneeded exit listener
* use common.mustCall()
* var -> const/let

PR-URL: #10189
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@italoacasas italoacasas mentioned this pull request Dec 15, 2016
Merged
targos pushed a commit that referenced this pull request Dec 28, 2016
@Trott @targos
test: refactor http pipelined socket test
dc993ac 
In test-http-incoming-pipelined-socket-destory:

* setTimeout() with no duration -> setImmediate()
* eliminate unneeded exit listener
* use common.mustCall()
* var -> const/let

PR-URL: #10189
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 22, 2017
@Trott @MylesBorins
test: refactor http pipelined socket test
2390fa9 
In test-http-incoming-pipelined-socket-destory:

* setTimeout() with no duration -> setImmediate()
* eliminate unneeded exit listener
* use common.mustCall()
* var -> const/let

PR-URL: #10189
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 22, 2017
@Trott @MylesBorins
test: refactor http pipelined socket test
8b378aa 
In test-http-incoming-pipelined-socket-destory:

* setTimeout() with no duration -> setImmediate()
* eliminate unneeded exit listener
* use common.mustCall()
* var -> const/let

PR-URL: #10189
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@Trott @MylesBorins
test: refactor http pipelined socket test
fe97fdd 
In test-http-incoming-pipelined-socket-destory:

* setTimeout() with no duration -> setImmediate()
* eliminate unneeded exit listener
* use common.mustCall()
* var -> const/let

PR-URL: #10189
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@Trott @MylesBorins
test: refactor http pipelined socket test
f1964fa 
In test-http-incoming-pipelined-socket-destory:

* setTimeout() with no duration -> setImmediate()
* eliminate unneeded exit listener
* use common.mustCall()
* var -> const/let

PR-URL: #10189
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This was referenced Jan 24, 2017
Merged
Merged
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
@Trott @MylesBorins
test: refactor http pipelined socket test
c57d720 
In test-http-incoming-pipelined-socket-destory:

* setTimeout() with no duration -> setImmediate()
* eliminate unneeded exit listener
* use common.mustCall()
* var -> const/let

PR-URL: #10189
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
@Trott @MylesBorins
test: refactor http pipelined socket test
121b68a 
In test-http-incoming-pipelined-socket-destory:

* setTimeout() with no duration -> setImmediate()
* eliminate unneeded exit listener
* use common.mustCall()
* var -> const/let

PR-URL: #10189
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@Trott Trott deleted the refactor-pipelined branch January 13, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@santigimeno santigimeno santigimeno approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @thefourtheye @santigimeno @cjihrig @MylesBorins @targos @nodejs-github-bot