v4.8.0 proposal #10973
Merged
v4.8.0 proposal #10973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
|
Noting that there is an intent to ship this release with #9771 but the current patch is failing. Once it passes another RC will be released ci: https://ci.nodejs.org/job/node-test-pull-request/6021/ edit: citgm on v4.7.2 for comparison: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/543/ |
mscdex
removed
build
|
Tomorrow, openssl will be updated. |
|
@shigeki I don't have a comment on whether to include in 4.8.0, or wait, but I would like to offer my help in backporting openssl to the LTS lines after it lands on master (or even to help land it on master). |
|
@sam-github Okay, I will notice you after my work. Thankfully, 0.12 and 0.10 and associated openssl-1.0.1 have already EOLS so we can only take caring of one version of 1.0.2. |
In most cases, named functions match the variable or property to which they are being assigned. That also seems to be the practice in a series of PRs currently being evaluated that name currently-anonymous functions. This change applies that rule to instances in the code base that don't comply with that practice. This will be enforceable with a lint rule once we upgrade to ESLint 3.8.0. PR-URL: #9113 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
The cherry-pick of #7612 to v4.x (4369055) added in #9298 wasn't quite correct as it depends on a runtime function %SymbolDescriptiveString that doesn't exist on v4.x. We can use %SymbolDescription instead. Ref: #7612 Ref: #9298 PR-URL: #10732 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This backport does not include the original changes to SLOW_DCHECK as it does not exist in the V8 in node v4.x Original commit message: Filter out stale left-trimmed handles BUG=chromium:620553 LOG=N R=jochen@chromium.org Review-Url: https://codereview.chromium.org/2078403002 Cr-Commit-Position: refs/heads/master@{#37108} PR-URL: #10668 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
This backport does not include the changes to `src/heap/scavenger.cc`
as it does not exist in the V8 included in the v4.x stream.
Original commit message:
Filter out stale left-trimmed handles for scavenges
The missing part from
https://codereview.chromium.org/2078403002/
R=jochen@chromium.org
BUG=chromium:621869
LOG=N
Review-Url: https://codereview.chromium.org/2077353004
Cr-Commit-Position: refs/heads/master@{#37184}
PR-URL: #10668
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
This commit does not include the changes to `src/heap/scavenger.cc`. These changes would revert the changes that should have come in 086bd5aede, meaning that there is no issue with that change missing in the previous commit. Original commit message: Iterate handles with special left-trim visitor BUG=chromium:620553 LOG=N R=hpayer@chromium.org Review-Url: https://codereview.chromium.org/2102243002 Cr-Commit-Position: refs/heads/master@{#37366} PR-URL: #10668 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
PR-URL: #10668 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Provide means to inspect information about the separate heap spaces via a callable API. This is helpful to analyze memory issues. Fixes: #2079 PR-URL: #4463 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
This commit adds a shell option, to spawn() and spawnSync(). This option allows child processes to be spawned with or without a shell. The option also allows a custom shell to be defined, for compatibility with exec()'s shell option. Fixes: #1009 PR-URL: #4598 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
This uses libuv's mkdtemp function to provide a way to create a
temporary folder, using a prefix as the path. The prefix is appended
six random characters. The callback function will receive the name
of the folder that was created.
Usage example:
fs.mkdtemp('/tmp/foo-', function(err, folder) {
console.log(folder);
// Prints: /tmp/foo-Tedi42
});
The fs.mkdtempSync version is also provided. Usage example:
console.log(fs.mkdtemp('/tmp/foo-'));
// Prints: tmp/foo-Tedi42
This pull request also includes the relevant documentation changes
and tests.
PR-URL: #5333
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
PR-URL: #9587 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Anna Henningsen <anna@addaleax.net>
- Replace require() vars with const. - Replace assert.equal() with assert.strictEqual(). - Add common.mustCall() to the setTimeout() callback. PR-URL: #9995 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Asserts that an error should be thrown when an invalid signal is passed to process.kill(). PR-URL: #10026 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Currently, there are a number of popups that get displayed when running the tests asking to accept incoming network connections. Rules can be added manually to the socket firewall on Mac OS X but getting this right might not be obvious and quite a lot of time can be wasted trying to get the rules right. This script hopes to simplify things a little so that it can be re-run when needed. The script should be runnable from both the projects root directory and from the tools directory, for example: $ sudo ./tools/macosx-firewall.sh Fixes: #8911 PR-URL: #10114 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* use common.mustCall() to confirm number of uncaught exceptions * var -> const * specify duration of 1ms for setTimeout() and setInterval() PR-URL: #10188 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Backport to v4.x Original commit message: Add process.cpuUsage() method that returns the user and system CPU time usage of the current process PR-URL: #6157 Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> PR-URL: #10796 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
cherry-pick 802a2e7 from v6-staging. ALPN is added to tls according to RFC7301, which supersedes NPN. When the server receives both NPN and ALPN extensions from the client, ALPN takes precedence over NPN and the server does not send NPN extension to the client. alpnProtocol in TLSSocket always returns false when no selected protocol exists by ALPN. In https server, http/1.1 token is always set when no options.ALPNProtocols exists. PR-URL: #2564 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
The assert.throws() calls in test-event-emitter-max-listeners.js should include a constructor or RegExp as a second argument. PR-URL: #9987 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
- Updated assert.equal to assert.strictEqual - Updated 'var' to 'const' - Using template literals PR-URL: #10036 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
Requiring a file from a directory that contains an invalid package.json file should throw an error. PR-URL: #10044 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* assert.equal() -> assert.strictEqual() * replace template string with a string; no variable substitution or concatenation or anything like that PR-URL: #9803 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
We have a tacit rule that for multiline statements, the operator should be placed before the linebreak. This commit commit fixes the few violations of this rule in the code base. This allows us to enable the corresponding ESLint rule. PR-URL: #10178 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Adds the `operator-linebreak` rule to our ESLint config. PR-URL: #10178 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
const and let instead var assert.strictEqual instead assert.equal PR-URL: #8668 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
force-pushed
the
v4.8.0-proposal
branch
from
0ee8e82 to
8e05acc
Compare
In closed environments, self-signed or privately signed certificates are commonly used, and rejected by Node.js since their root CAs are not well-known. Allow extending the set of well-known compiled-in CAs via environment, so they can be set as a matter of policy. PR-URL: #9139 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
As it is, each line in the deprecation heading which are wrapped at 80
characters in the *.md files, are shown in different lines. For example
> Stability: 0 - Deprecated: Use
> `Buffer.from(arrayBuffer[, byteOffset [, length]])`
> instead.
is shown in three different lines. This patch replaces the newlines
with space characters, so that the output will be in single line.
PR-URL: #11074
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
The `hints` value will be a number. To specify more than one hints, their corresponding bits have to be set. So bitwise OR should be used instead of logical OR. PR-URL: #11037 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
`killSignal` option accepts the signal name or signal number as well. PR-URL: #10424 Reviewed-By: Julian Duque <julianduquej@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
MylesBorins
force-pushed
the
v4.8.0-proposal
branch
from
8e05acc to
1b24ba8
Compare
|
New rc that includes the extra certs changes |
|
Following on my comment on the 6.10 RC Pull Request, I've had the opportunity to re-run my tests using v4.8.0-rc.3. My tests include:
My operating environment requires that SSL traffic get re-encrypted. Using the certificate extension feature from #9139, setting the NODE_EXTRA_CA_CERTS environment variable as listed above, I was able to interact with HTTPS URLs successfully. On a related note, the certificate I passed originally contained both the self-signed certificate and a copy of Mozilla's certificates (as already contained in Node). Because there were certificate duplicates I received the following warning: Warning: Ignoring extra certs from `path/to/cert`, load failed: error:0B07C065:x509 certificate routines:X509_STORE_add_cert:cert already in hash tableMy test still passed since the message was only a warning, indicating that some certificates could not be added. Based on my understanding of the code in #9139, this is expected behavior. All around great work. Thank you! |
__dirname is path.dirname(__filename), but its docs, specifically the attempt to describe javascript scope in terms of "running" and "executing" had drifted apart. Rework to describe one as a variation of the other, move the example, and just describe the names in terms of the module, and it's local variables rather than the ill defined execution concepts. Fix: #5525 PR-URL: #10527 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Added note about vcbuild being included as batch to clarify that it's not needed from msbuild tools or visual studio. PR-URL: #8704 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Corrected parameter for running tests on Windows. Without the corrected parameters, Windows users encounter an error about failing to sign the build, "Failed to sign exe", which can be discouraging to new Windows community members. PR-URL: #10686 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Currently, when a process times out, it is terminated by sending it the SIGTERM signal. Sending SIGBART instead allows the operating system to generate a core file that can be investigated later using post-mortem debuggers such as llnode or mdb_v8. This can be very useful when investigating flaky tests that time out, since in that case the failure is difficult to reproduce, and being able to look at a core file makes a big difference. With these changes, passing the --abort-on-timeout command line option to tools/test.py now sends SIGABRT to processes timing out on all platforms but Windows. PR-URL: #11086 Ref: #11026 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
#11086 had introduced a regression that broke command line options processing for tools/test.py. Basically, it made tools/test.py discard the command line argument that would be passed after `--abort-on-timeout`. For instance, when running: ``` $ python tools/test.py --abort-on-timeout path/to/some-test ``` all tests would be run because the last command line argument (`/path/to/some-test`) would be discarded. This change fixes this regression. Refs: #11086 PR-URL: #11153 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
force-pushed
the
v4.8.0-proposal
branch
from
1b24ba8 to
64b86b2
Compare
Notable Changes: * child_process: add shell option to spawn() (cjihrig) #4598 * crypto: * add ALPN Support (Shigeki Ohtsu) #2564 * allow adding extra certs to well-known CAs (Sam Roberts) #9139 * deps: * v8: expose statistics about heap spaces (Ben Ripkens) #4463 * fs: add the fs.mkdtemp() function. (Florian MARGAINE) #5333 * process: * add `externalMemory` to `process` (Fedor Indutny) #9587 * add process.cpuUsage() (Patrick Mueller) #10796
MylesBorins
force-pushed
the
v4.8.0-proposal
branch
from
64b86b2 to
58ab54f
Compare
|
One more CI + citgm https://ci.nodejs.org/job/node-test-commit/8056/ edit: CI is good. |
MylesBorins
added a commit
that referenced
this pull request
Feb 22, 2017
Notable Changes: * child_process: add shell option to spawn() (cjihrig) #4598 * crypto: * add ALPN Support (Shigeki Ohtsu) #2564 * allow adding extra certs to well-known CAs (Sam Roberts) #9139 * deps: * v8: expose statistics about heap spaces (Ben Ripkens) #4463 * fs: add the fs.mkdtemp() function. (Florian MARGAINE) #5333 * process: * add `externalMemory` to `process` (Fedor Indutny) #9587 * add process.cpuUsage() (Patrick Mueller) #10796 PR-URL: #10973
MylesBorins
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Feb 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2017-02-21, Version 4.8.0 'Argon' (LTS), @MylesBorins
Notable Changes
Coming Soon
Commits
78010aa0cd] - build: add /opt/freeware/... to AIX library path (Stewart X Addison) #101280bb77f24fa] - build: add (not) cross-compiled configure flags (Jesús Leganés-Combarro 'piranna) #1028758245225ef] - (SEMVER-MINOR) child_process: add shell option to spawn() (cjihrig) #45981595328b44] - (SEMVER-MINOR) crypto: allow adding extra certs to well-known CAs (Sam Roberts) #9139bf882fba35] - crypto: Use reference count to manage cert_store (Adam Majer) #94094cf7dcff99] - crypto: remove unnecessary variables of alpn/npn (Shigeki Ohtsu) #10831d8b902f787] - debugger: callthis.resume()afterthis.run()(Lance Ball) #100994e07bd45d6] - deps: update patch level in V8 (Myles Borins) #10668a234d445c4] - deps: backport a715957 from V8 upstream (Myles Borins) #10668ce66c8e424] - deps: backport 7a88ff3 from V8 upstream (Myles Borins) #106688bd3d83e01] - deps: backport d800a65 from V8 upstream (Myles Borins) #1066881e9a3bfcb] - deps: V8: fix debug backtrace for symbols (Ali Ijaz Sheikh) #107328eeccd82d2] - doc: killSignal option accepts integer values (Sakthipriyan Vairamani (thefourtheye)) #104247db7e47d7b] - doc: change logical to bitwise OR in dns lookup (Sakthipriyan Vairamani (thefourtheye)) #1103728b707ba42] - doc: replace newlines in deprecation with space (Sakthipriyan Vairamani (thefourtheye)) #1107479d49866f2] - doc: update CONTRIBUTING.MD with link to V8 guide (sarahmeyer) #10070acbe4d3516] - doc: add joyeecheung to collaborators (Joyee Cheung) #10603c7378c4d5f] - doc: warn about unvalidated input in child_process (Matthew Garrett) #1046608e924e45c] - doc: require two-factor authentication (Rich Trott) #10529d260fb2e7e] - doc: use "Node.js" in V8 guide (Rich Trott) #104384f168a4a31] - doc: require() tries first core not native modules (Vicente Jimenez Aguilar) #103245777c79c52] - doc: clarify the review and landing process (Joyee Cheung) #10202d3a7fb8a9e] - doc: redirect 'Start a Working Group' to TSC repo (William Kapke) #96550e51cbb827] - doc: add Working Group dissolution text (William Kapke) #9656919e0cb8f2] - doc: more efficient example in the console.md (Vse Mozhet Byt) #1045170ea38f2ee] - doc: var -> const / let in the console.md (Vse Mozhet Byt) #10451dda777bf9e] - doc: consistent 'Returns:' part two (Myles Borins) #103913b252a69a0] - doc: clarify macosx-firewall suggestion BUILDING (Chase Starr) #10311c4df02c815] - doc: add Michaël Zasso to the CTC (Michaël Zasso)2269d7db0f] - (SEMVER-MINOR) fs: add the fs.mkdtemp() function. (Florian MARGAINE) #53332eda3c7c75] - lib,test: use consistent operator linebreak style (Michaël Zasso) #101787505b86d2f] - os: fix os.release() for aix and add test (jBarz) #102457a9c8d8f10] - process: add process.cpuUsage() - implementation, doc, tests (Patrick Mueller) #1079623a573f7cb] - (SEMVER-MINOR) process: addprocess.memoryUsage.external(Fedor Indutny) #9587be6203715a] - src: describe what NODE_MODULE_VERSION is for (Sam Roberts) #104143f29cbb5bc] - src: fix string format mistake for 32 bit node (Alex Newman) #10082271f5783fe] - stream, test: test _readableState.emittedReadable (Joyee Cheung) #10249735119c6fb] - test: cleanup stream tests (Italo A. Casas) #8668f9f8e4ee3e] - test: refactor test-preload (Rich Trott) #9803e7c4dfb83b] - test: invalid package.json causes error when require()ing in directory (Sam Shull) #1004422226fa900] - test: refactoring test-pipe-head (Travis Bretton) #1003611115c0d85] - test: add second argument to assert.throws() (Ken Russo) #998796ca40bdd8] - test: refactor test-tls-0-dns-altname (Richard Karmazin) #994898496b6d3e] - test: test: refactor test-sync-fileread (Jason Wohlgemuth) #9941324c82b1c9] - test: use common.fixturesDir almost everywhere (Bryan English) #6997ce91bb21ba] - test: refactor test-repl-mode.js (Cesar Hernandez) #1006161cbc202a1] - test: refactor test-net-dns-custom-lookup (Kent.Fan) #10071812c6361ff] - test: refactor test-tls-server-verify (Hutson Betts) #1007619907c27a6] - test: use mustCall() for simple flow tracking (cjihrig) #775342da81e6cc] - test: set stdin too for pseudo-tty tests (Anna Henningsen) #1014953404dbc1f] - test: add stdin-setrawmode.out file (Jonathan Darling) #101491fac431307] - test: add tests for clearBuffer state machine (Safia Abdalla) #992237a362275e] - test: update test-cluster-shared-handle-bind-error (cjihrig) #10547f5e54f5d5f] - test: avoid assigning this to variables (cjihrig) #1054828a5ce10af] - test: improve test-http-allow-req-after-204-res (Adrian Estrada) #1050352edebc8f3] - test: improve test-fs-empty-readStream.js (Adrian Estrada) #10479b74bc517a6] - test: use strictEqual in test-http-server (Fabrice Tatieze) #10478a9cd1d1267] - test: refactor test-stream2-unpipe-drain (Chris Story) #100337020e9fd8b] - test: add test for SIGWINCH handling by stdio.js (Sarah Meyer) #1006356b193a9c2] - test: improve code in test-vm-preserves-property (Adrian Estrada) #104288a26ba142f] - test: fix flaky test-https-timeout (Rich Trott) #10404eeb2d7885a] - test: improve test-cluster-worker-constructor.js (Adrian Estrada) #10396fd195b47d6] - test: stream readable resumeScheduled state (Italo A. Casas) #10299135a7c9e19] - test: stream readable needReadable state (Joyee Cheung) #10241f412b1fcfd] - test: clean up domain-no-error-handler test (weyj4) #1029114c28ebcf1] - test: update test-domain-uncaught-exception.js (Andy Chen) #10193928291c652] - test: refactor test-domain.js (Siddhartha Sahai) #1020713c6cec433] - test: fail for missing output files (Anna Henningsen) #10150544920f77b] - test: stream readableState readingMore state (Gregory) #98682f8bc9a7bc] - test: s/ASSERT/assert/ (cjihrig) #10544380a5d5e12] - test: fix flaky test-http-client-timeout-with-data (Rich Trott) #1043114e07c96e1] - test: refactor test-stdin-from-file (Rob Adelmann) #10331424c86139d] - test: refactor the code in test-fs-chmod (Adrian Estrada) #1044031aa877003] - test: improve the code in test-pipe.js (Adrian Estrada) #104524bbd50ee07] - test: improve code in test-fs-readfile-error (Adrian Estrada) #103679840f505f0] - test: improve code in test-vm-symbols (Adrian Estrada) #104294efdbafeb3] - test: refactor test-child-process-ipc (malen) #9990dbfec29663] - test: fix and improve debug-break-on-uncaught (Sakthipriyan Vairamani (thefourtheye)) #1037080f4a37023] - test: refactor test-pipe-file-to-http (Josh Mays) #10054a983400ac2] - test: refactor test-tls-interleave (Brian Chirgwin) #100176db76da2c8] - test: refactor test-cluster-send-handle-twice.js (Amar Zavery) #1004919b314e40a] - test: update test-tls-check-server-identity.js (Kevin Cox) #9986ab3e4c6a9b] - test: improve test-cluster-net-listen.js (Rico Cai) #9953fb9a0ad6c0] - test: refactor test-child-process-stdin (Segu Riluvan) #10420122917df5a] - test: change var declarations, add mustCall check (Daniel Sims) #9962d5e911c51e] - test: refactoring test-cluster-worker-constructor (Christopher Rokita) #99567d61bbf647] - test: refactor test-stdin-script-child (Emanuel Buholzer) #1032176bb3cbff9] - test: refactor test-stream2-writable (Rich Trott) #10353b87ee26b96] - test: change assert.strict to assert.strictEqual() (Ashita Nagesh) #99884514fd78f4] - test: refactor the code in test-http-keep-alive (Adrian Estrada) #10350f301df405a] - test: use strictEqual in test-cwd-enoent-repl.js (Neeraj Sharma) #99523b67001c99] - test: refactor test-net-reconnect-error (Duy Le) #990334861efff6] - test: add test-require-invalid-package (Duy Le) #990390a79b3967] - test: refactor test-timers-this (Rich Trott) #103155335b0a0d1] - test: refactor test-tls-ecdh-disable (Aaron Williams) #99890f8a323546] - test: cleanup test-stdout-close-catch.js (Travis Bretton) #10006fc67a955e2] - test: use const/let and common.mustCall (Outsider) #99592f44d7f367] - test: refactor test-crypto-random (Rich Trott) #10232730c3b29e8] - test: refactor test-fs-fsync (Rob Adelmann) #101769c9d422433] - test: refactor test-http-after-connect.js (larissayvette) #10229827bbe7985] - test: refactor assert.equal, update syntax to ES6 (Prieto, Marcos)121b68a283] - test: refactor http pipelined socket test (Rich Trott) #101897ca31e38fb] - test: fix alpn tests for openssl1.0.2h (Shigeki Ohtsu) #6550278d718a93] - test: refactor test-handle-wrap-close-abort (Rich Trott) #10188f12bab65b8] - test: stream readableListening internal state (Italo A. Casas) #9864210290dfba] - test: check for error on invalid signal (Matt Phillips) #100264f5f0e4975] - test: refactor test-net-keepalive.js (Kyle Corsi) #9995cfa2b87b5d] - test,lib,benchmark: match function names (Rich Trott) #9113a67ada7d32] - tls: copy the Buffer object before using (Sakthipriyan Vairamani) #8055e750f142ce] - (SEMVER-MINOR) tls, crypto: add ALPN Support (Shigeki Ohtsu) #2564ef547f3325] - (SEMVER-MINOR) tls,crypto: move NPN protcol data to hidden value (Shigeki Ohtsu) #256431434a1202] - tools: enforce consistent operator linebreak style (Michaël Zasso) #101789f13b5f7d5] - tools: forbid template literals in assert.throws (Michaël Zasso) #10301c801de9814] - tools: add ESLint rule for assert.throws arguments (Michaël Zasso) #10089b5e18f207f] - tools: add macosx-firwall script to avoid popups (Daniel Bevenius) #1011430d60cf81c] - (SEMVER-MINOR) v8,src: expose statistics about heap spaces (Ben Ripkens) #44639556ef3241] - vm: add error message if we abort (Franziska Hinkelmann) #8634fa11f4b1fc] - win,msi: add required UIRef for localized strings (Bill Ticehurst) #8884