Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream, test: test for _readableState.emittedReadable #10249

Closed
wants to merge 1 commit into from
Closed

stream, test: test for _readableState.emittedReadable #10249

wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

stream, test

Description of change

Part of #10230, increase coverage of the internal state machine of streams.

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v4.x labels Dec 13, 2016
@joyeecheung joyeecheung changed the title stream, test: test for _readableState.needReadable stream, test: test for _readableState.emittedReadable Dec 13, 2016
@joyeecheung
stream, test: test _readableState.emittedReadable
83e6738 
Part of nodejs#10230, increase coverage of the internal
state machine of streams.
@joyeecheung joyeecheung force-pushed the test-emitted-readable branch from 7ec1cf5 to 83e6738 Compare December 13, 2016 14:59
@joyeecheung
Copy link
Member Author

Sorry, copied the commit message from #10241, should be emittedReadable, not needReadable.

@mscdex mscdex added the stream Issues and PRs related to the stream subsystem. label Dec 13, 2016
@italoacasas
Copy link
Contributor

Related to #8683

mcollina
mcollina approved these changes Dec 16, 2016
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina
Copy link
Member

@joyeecheung can you please amend your commit and say that it is part of #8683

@mcollina
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/5435/

@mcollina
Copy link
Member

Landing

@mcollina
Copy link
Member

Landed in 8127501.

@mcollina mcollina closed this Dec 16, 2016
mcollina pushed a commit that referenced this pull request Dec 16, 2016
@joyeecheung @mcollina
stream, test: test _readableState.emittedReadable
8127501 
Part of #8683, increase coverage of the internal
state machine of streams.

PR-URL: #10249
See: #8683
See: #10230
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
italoacasas pushed a commit that referenced this pull request Dec 17, 2016
@joyeecheung @italoacasas
stream, test: test _readableState.emittedReadable
28ffd59 
Part of #8683, increase coverage of the internal
state machine of streams.

PR-URL: #10249
See: #8683
See: #10230
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@italoacasas italoacasas mentioned this pull request Dec 17, 2016
Merged
cjihrig pushed a commit that referenced this pull request Dec 20, 2016
@joyeecheung @cjihrig
stream, test: test _readableState.emittedReadable
8ddbd53 
Part of #8683, increase coverage of the internal
state machine of streams.

PR-URL: #10249
See: #8683
See: #10230
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@joyeecheung joyeecheung deleted the test-emitted-readable branch January 2, 2017 05:28
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
@joyeecheung @MylesBorins
stream, test: test _readableState.emittedReadable
f26213a 
Part of #8683, increase coverage of the internal
state machine of streams.

PR-URL: #10249
See: #8683
See: #10230
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
@joyeecheung @MylesBorins
stream, test: test _readableState.emittedReadable
9fa1e7d 
Part of #8683, increase coverage of the internal
state machine of streams.

PR-URL: #10249
See: #8683
See: #10230
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@joyeecheung @MylesBorins
stream, test: test _readableState.emittedReadable
1f6b10d 
Part of #8683, increase coverage of the internal
state machine of streams.

PR-URL: #10249
See: #8683
See: #10230
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@joyeecheung @MylesBorins
stream, test: test _readableState.emittedReadable
a023886 
Part of #8683, increase coverage of the internal
state machine of streams.

PR-URL: #10249
See: #8683
See: #10230
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This was referenced Jan 24, 2017
Merged
Merged
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
@joyeecheung @MylesBorins
stream, test: test _readableState.emittedReadable
9a84162 
Part of #8683, increase coverage of the internal
state machine of streams.

PR-URL: #10249
See: #8683
See: #10230
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
@joyeecheung @MylesBorins
stream, test: test _readableState.emittedReadable
271f578 
Part of #8683, increase coverage of the internal
state machine of streams.

PR-URL: #10249
See: #8683
See: #10230
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@joyeecheung @italoacasas @mcollina @mscdex @MylesBorins @nodejs-github-bot